From: "David Hildenbrand (Arm)" <david@kernel.org>
To: Breno Leitao <leitao@debian.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Miaohe Lin <linmiaohe@huawei.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-trace-kernel@vger.kernel.org, kernel-team@meta.com,
Lorenzo Stoakes <ljs@kernel.org>,
Vlastimil Babka <vbabka@kernel.org>,
Mike Rapoport <rppt@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>, Shuah Khan <shuah@kernel.org>,
Naoya Horiguchi <nao.horiguchi@gmail.com>,
Jonathan Corbet <corbet@lwn.net>,
Shuah Khan <skhan@linuxfoundation.org>,
"Liam R. Howlett" <liam@infradead.org>,
lance.yang@linux.dev, Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Subject: Re: [PATCH v10 6/6] selftests/mm: add hwpoison-panic destructive test
Date: Wed, 29 Jul 2026 09:25:16 +0200 [thread overview]
Message-ID: <f83d5b26-b369-489b-a305-1eb5ec6fccfb@kernel.org> (raw)
In-Reply-To: <amkn21ftNme48Vbl@gmail.com>
On 7/29/26 00:07, Breno Leitao wrote:
> On Tue, Jul 28, 2026 at 09:21:40PM +0200, David Hildenbrand (Arm) wrote:
>> On 7/28/26 21:20, Andrew Morton wrote:
>>>
>>>
>>> The bash script is still there, no known issues.
>>>
>>> We have the thing and tests are useful. I'd say retain it until the
>>> rewrite-in-C happens?
>>
>> Nacked-by: David Hildenbrand <david@kernel.org>
>
> I have a draft of the selftest in C already and I will give it more bake
> time, and I will submit it until EOW.
IMHO there is no need to rush this test here, we could merge it after the main work.
We neglected our selftests quite a bit in the past, and that is biting us now.
That's why I push back hard now (sorry) against stuff that is different than the
rest and not easy to maintain.
I know, hwpoison-panic is a destructive test, but I really don't think we should
just merge mostly unreviewed bash tests that will just bitrot.
Which makes me wonder now: should this actually be a selftest? It's nothing one
would just want to run in a CI. It will crash your machine.
Maybe this should just be a tool in tools/mm? I really think so. So having a
nice C-level hwpoison-panic.c in tools/mm might be the way to go.
So let's rather make this test well maintainable and have it properly reviewed
than rushing something suboptimal.
--
Cheers,
David
next prev parent reply other threads:[~2026-07-29 7:25 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-30 12:46 [PATCH v10 0/6] mm/memory-failure: add panic option for unrecoverable pages Breno Leitao
2026-06-30 12:46 ` [PATCH v10 1/6] mm/memory-failure: drop dead error_states[] entry for reserved pages Breno Leitao
2026-06-30 12:46 ` [PATCH v10 2/6] mm/memory-failure: surface unhandlable kernel pages as -ENOTRECOVERABLE Breno Leitao
2026-07-06 12:22 ` Miaohe Lin
2026-06-30 12:46 ` [PATCH v10 3/6] mm/memory-failure: report MF_MSG_KERNEL for unrecoverable kernel pages Breno Leitao
2026-06-30 12:46 ` [PATCH v10 4/6] mm/memory-failure: add panic option for unrecoverable pages Breno Leitao
2026-06-30 12:46 ` [PATCH v10 5/6] Documentation: document panic_on_unrecoverable_memory_failure sysctl Breno Leitao
2026-07-09 3:18 ` Miaohe Lin
2026-06-30 12:46 ` [PATCH v10 6/6] selftests/mm: add hwpoison-panic destructive test Breno Leitao
2026-07-04 9:31 ` Mike Rapoport
2026-07-06 16:14 ` Breno Leitao
2026-07-06 16:23 ` Mike Rapoport
2026-07-09 3:34 ` Miaohe Lin
2026-07-28 4:24 ` Andrew Morton
2026-07-28 8:57 ` Miaohe Lin
2026-07-28 9:29 ` Breno Leitao
2026-07-28 19:20 ` Andrew Morton
2026-07-28 19:21 ` David Hildenbrand (Arm)
2026-07-28 22:07 ` Breno Leitao
2026-07-29 7:25 ` David Hildenbrand (Arm) [this message]
2026-07-29 8:53 ` Breno Leitao
2026-07-29 9:09 ` David Hildenbrand (Arm)
2026-07-28 9:35 ` David Hildenbrand (Arm)
2026-06-30 20:55 ` [PATCH v10 0/6] mm/memory-failure: add panic option for unrecoverable pages Andrew Morton
-- strict thread matches above, loose matches on Subject: below --
2026-06-26 15:33 Breno Leitao
2026-06-26 15:33 ` [PATCH v10 6/6] selftests/mm: add hwpoison-panic destructive test Breno Leitao
2026-06-27 7:52 ` Mike Rapoport
2026-06-29 15:50 ` Breno Leitao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f83d5b26-b369-489b-a305-1eb5ec6fccfb@kernel.org \
--to=david@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=kernel-team@meta.com \
--cc=lance.yang@linux.dev \
--cc=leitao@debian.org \
--cc=liam@infradead.org \
--cc=linmiaohe@huawei.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=ljs@kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=mhocko@suse.com \
--cc=nao.horiguchi@gmail.com \
--cc=rostedt@goodmis.org \
--cc=rppt@kernel.org \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox