From: Jens Axboe <axboe@kernel.dk>
To: Keith Busch <kbusch@meta.com>,
linux-kernel@vger.kernel.org,
Alexander Viro <viro@zeniv.linux.org.uk>
Cc: linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, hch@lst.de,
io-uring@vger.kernel.org, Pavel Begunkov <asml.silence@gmail.com>,
Eric Dumazet <edumazet@google.com>,
Steven Rostedt <rostedt@goodmis.org>,
davem@davemloft.net, Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
David Howells <dhowells@redhat.com>,
Jarkko Sakkinen <jarkko@kernel.org>,
Paul Moore <paul@paul-moore.com>,
keyrings@vger.kernel.org, linux-security-module@vger.kernel.org,
linux-trace-kernel@vger.kernel.org, linux-block@vger.kernel.org,
netdev@vger.kernel.org, Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCHv2 00/12] iov_iter: replace import_single_range with ubuf
Date: Sun, 8 Jan 2023 20:51:43 -0700 [thread overview]
Message-ID: <f9ca2051-741b-e4bb-74c5-178778c788df@kernel.dk> (raw)
In-Reply-To: <20230105190741.2405013-1-kbusch@meta.com>
On 1/5/23 12:07 PM, Keith Busch wrote:
> From: Keith Busch <kbusch@kernel.org>
>
> ITER_UBUF is a more efficient representation when using single vector
> buffers, providing small optimizations over ITER_IOVEC. This series
> introduces a helper to set these up, and replaces all applicable users
> of import_single_range with the new helper. And since there are no
> single range users left after this change, the helper is no longer
> needed.
>
> As noted in v1(*), there are some fundamental differences to how io_uring
> compares to read/write/readv/writev. There are only the two affected
> file_operations, and they already do not work with io_uring due to their
> diverging semantics for vectored vs non-vectored read/write. Therefore,
> this series having io_uring prefer ubuf iov_iter isn't introducing new
> breakage.
Pondering how to stage this, both for later upstream but also for
testing. Would probably make the best sense to stage 1-5 separately,
and then just punt the remaining ones to the appropriate subsystems.
And then 12/12 can go in when they have all been applied.
--
Jens Axboe
next prev parent reply other threads:[~2023-01-09 3:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230105190741.2405013-1-kbusch@meta.com>
2023-01-08 17:12 ` [PATCHv2 00/12] iov_iter: replace import_single_range with ubuf Christoph Hellwig
[not found] ` <20230105190741.2405013-3-kbusch@meta.com>
2023-01-09 3:49 ` [PATCHv2 02/12] io_uring: switch network send/recv to ITER_UBUF Jens Axboe
2023-01-09 3:51 ` Jens Axboe [this message]
2023-01-09 9:31 ` [PATCHv2 00/12] iov_iter: replace import_single_range with ubuf David Howells
2023-01-09 15:12 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9ca2051-741b-e4bb-74c5-178778c788df@kernel.dk \
--to=axboe@kernel.dk \
--cc=asml.silence@gmail.com \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=edumazet@google.com \
--cc=hch@lst.de \
--cc=io-uring@vger.kernel.org \
--cc=jarkko@kernel.org \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
--cc=keyrings@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-aio@kvack.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=paul@paul-moore.com \
--cc=rostedt@goodmis.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).