From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 54E664F3914; Fri, 9 Oct 2026 18:49:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791571752; cv=none; b=aI9VP0dhVcbCEeHHucPTz2fFxcJBHPfhts93NjHwNsHSVd+Uhmb0aI+1D7px3VfViRMJIUvc2xJYE2zkXtMTfsNZz0P1OBS+G7GkgZfbu9cPuGz5SKfw3TiOXQwOZJ7jq4+ckTn/Ka9a01WS0y/46VeK5PKXAPUoFMjzCtJhSMg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791571752; c=relaxed/simple; bh=O3hl0CgJ8hJt5Vn6Rrv76b8YeVHvaAYVx4UhQfyf/Gk=; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type: Date; b=UZ5FerZDyqN+ZzFiCCeCCL7s1Rx1K6KV77cAKydJ081ZG0BCxYKUc0/PPdLsMmGRuo0KwZxuzzuikt5GVo2cplZm0ts67MauZE1OhT+Z46ASDnERMxElumIKufUTqaly3nWdFDSU2U4TpI/lEczDjKJ4oCUGkKGmWXeAdWf5DR8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=TZ5rAexz; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="TZ5rAexz" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AC81C1F000FF; Fri, 9 Oct 2026 18:49:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1791571750; bh=O3hl0CgJ8hJt5Vn6Rrv76b8YeVHvaAYVx4UhQfyf/Gk=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=TZ5rAexzQX9pb3RldVcXkpUp9sxsORHrSKjj9c1kAsE2l2/q0aZnqI9RZvie4v6V/ 8ZsBJED75V5m6dwfvCWoO5GEib1bXkykJw1woz7q7T9Rtht5HB7mOYq/kfpGBKvYF9 IdZF+G/3Qqkla+4WsOfHLUoJbvv29k2OS25FUXbWk5ZiDGkmsKc/qzeWmHdHBvtuZY BzXHSyal6EGxBl0jqRnq4lEP8qErw8Ata9jgJ63hwh6fPzuYN8+QdM16SDUDYKw6tO 0VEmDHCcEIc0DmW0WMDshINXTEsi96frDfKf5vUK6jXf+7aAk3KPtHtSON5qA3dvq1 pR50ZHlOwpGJQ== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v5 23/38] mm/mlock: eliminate weird VMA_IO_BIT abuse and simplify Reply-To: sashiko-reviews@lists.linux.dev To: =?utf-8?b?TG9yZW56byBTdG9ha2VzIChBUk0p?= Cc: "Heiko Carstens" , dri-devel@lists.freedesktop.org, linux-usb@vger.kernel.org, "Vasily Gorbik" , linux-perf-users@vger.kernel.org, kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, "Oliver Upton" , "Alexander Gordeev" , "Christian Borntraeger" , linux-trace-kernel@vger.kernel.org, selinux@vger.kernel.org, linux-rdma@vger.kernel.org, kvmarm@lists.linux.dev, "Marc Zyngier" , bpf@vger.kernel.org In-Reply-To: <20261009-b4-mmap-prepare-vma-flag-sanify-v5-23-923b70125b1e@kernel.org> References: <20261009-b4-mmap-prepare-vma-flag-sanify-v5-0-923b70125b1e@kernel.org> <20261009-b4-mmap-prepare-vma-flag-sanify-v5-23-923b70125b1e@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 09 Oct 2026 18:49:09 +0000 Precedence: bulk X-Mailing-List: linux-trace-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: > When performing mlock() or munlock() otherwise normal VMAs have VMA_IO_BIT > solely to fix a race with migration which might otherwise double-count > mlock VMAs. >=20 > This is unnecessary - at the point of applying folio mlock state, whether > setting or clearing PG_mlocked, we know whether or not we are locking. >=20 > Solve this in two ways - thread a boolean through the page table walk > indicating whether a lock or unlock is being performed, and run a locking > walk with VMA_LOCKONFAULT_BIT set and VMA_LOCKED_BIT cleared. >=20 > This state never occurs otherwise, as VMA_LOCKONFAULT_BIT always implies > VMA_LOCKED_BIT. These are also always cleared together. >=20 > Then, update folio_add_lru_vma() and mlock_folio() to check only for > [ ... ] >=20 > While here, also replace some deprecated VMA flag predicates. >=20 > Reviewed-by: Zi Yan > Signed-off-by: Lorenzo Stoakes (ARM) Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261009-b4-mmap-pr= epare-vma-flag-sanify-v5-0-923b70125b1e@kernel.org?part=3D23