Re: [PATCH RFC v3 08/14] i2c: uapi: add I2C_XFER_V2 ioctl - detailed fault reporting

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] i2c: uapi: commit message refers to I2C_XFER_V2 instead of I2C_RDWR_V2
--

commit 469565334f01910f1574884cc7c0897afa2334bd
Author: Dmitry Guzman <Dmitry.Guzman@mobileye.com>

i2c: uapi: add I2C_XFER_V2 ioctl - detailed fault reporting

This commit adds the I2C_RDWR_V2 ioctl command and struct
i2c_rdwr_v2_ioctl_data to include/uapi/linux/i2c-dev.h to support
multi-message I2C transfers with detailed fault reporting.

>     i2c: uapi: add I2C_XFER_V2 ioctl - detailed fault reporting
>     
>     For user-space access to I2C multi-message transfer with detailed
>     reporting functionality, add I2C_XFER_V2 ioctl and corresponding
>     struct i2c_rdwr_v2_ioctl_data.
>     
>     The structure consists of struct i2c_rdwr_ioctl_data that used in the
>     same way as in I2C_XFER, and struct i2c_transfer_report that the
>     detailed transfer report is put in.
>     
>     Signed-off-by: Dmitry Guzman <Dmitry.Guzman@mobileye.com>

[Severity: Low]
This isn't a bug, but the commit subject and message refer to I2C_XFER_V2
and I2C_XFER, whereas include/uapi/linux/i2c-dev.h defines I2C_RDWR_V2
alongside the existing I2C_RDWR ioctl:

include/uapi/linux/i2c-dev.h:
#define I2C_RDWR	0x0707	/* Combined R/W transfer (one STOP only) */
#define I2C_RDWR_V2	0x0709  /* I2C_RDWR with detailed fault reporting */

Should the commit subject and message be updated to reference I2C_RDWR_V2
and I2C_RDWR instead?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261105-i2c-fault-reporting-v3-0-515ad74ac4c9@mobileye.com?part=8