Linux Trace Kernel
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Avi Weiss" <thnkslprpt@gmail.com>
Cc: linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH] tracing: Restore custom event creation selector
Date: Fri, 20 Nov 2026 12:37:24 +0000	[thread overview]
Message-ID: <sashiko-outbox-225150@kernel.org> (raw)
In-Reply-To: <20261120122837.1597798-2-thnkslprpt@gmail.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] tracing: duplicate str__custom__trace_system_name on second
  custom header
--

commit e451694c0169b91ce25bbac13cc9b1321c4dd71b
Author: Avi Weiss <thnkslprpt@gmail.com>

tracing: Restore custom event creation selector

This commit restores CREATE_CUSTOM_TRACE_EVENTS instead of
CREATE_CUSTOM_TRACE_POINTS at the end of include/trace/define_custom_trace.h
so subsequent custom event headers in the same translation unit are not
skipped.

> diff --git a/include/trace/define_custom_trace.h b/include/trace/define_custom_trace.h
> index 5827a4c92c744..177c628f2d567 100644
> --- a/include/trace/define_custom_trace.h
> +++ b/include/trace/define_custom_trace.h
> @@ -72,6 +72,6 @@
>  #endif
>  
>  /* We may be processing more files */
> -#define CREATE_CUSTOM_TRACE_POINTS
> +#define CREATE_CUSTOM_TRACE_EVENTS
>  
> -#endif /* CREATE_CUSTOM_TRACE_POINTS */
> +#endif /* CREATE_CUSTOM_TRACE_EVENTS */

[Severity: Medium]
Does including a second custom event header under CREATE_CUSTOM_TRACE_EVENTS
now fail to compile with a redefinition of str__custom__trace_system_name?

Each inclusion of include/trace/define_custom_trace.h includes
include/trace/trace_custom_events.h, which sets TRACE_SYSTEM to custom and
includes include/trace/stages/init.h:

include/trace/trace_custom_events.h:
#undef TRACE_SYSTEM
#define TRACE_SYSTEM custom

#ifndef TRACE_SYSTEM_VAR
#define TRACE_SYSTEM_VAR TRACE_SYSTEM
#endif

/* The init stage creates the system string and enum mappings */

#include "stages/init.h"

include/trace/stages/init.h then invokes TRACE_MAKE_SYSTEM_STR() to emit
static const char str__custom__trace_system_name[] = "custom"; on every
pass, because all custom event headers share the custom TRACE_SYSTEM and
the definition is not guarded against multiple inclusions in the same
translation unit.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261120122837.1597798-2-thnkslprpt@gmail.com?part=1

      reply	other threads:[~2026-11-20 12:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20 12:28 [PATCH] tracing: Restore custom event creation selector Avi Weiss
2026-11-20 12:37 ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-225150@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=thnkslprpt@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox