Linux Trace Kernel
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Chaosheng Qu" <chaosheng.qu.linux@gmail.com>
Cc: linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] verification/rvgen: Validate the monitor type
Date: Sat, 21 Nov 2026 11:36:30 +0000	[thread overview]
Message-ID: <sashiko-outbox-226981@kernel.org> (raw)
In-Reply-To: <cf05914335850f6835ae79b34d6b4ad891128948.1795252297.git.chaosheng.qu.linux@gmail.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] verification/rvgen: missing Fixes: trailer for monitor_type
  validation
--

commit 3e56be70e8ab6364389874866af8ed0012adb35b
Author: Chaosheng Qu <chaosheng.qu.linux@gmail.com>

> verification/rvgen: Validate the monitor type
>
> The monitor type is pasted into the generated monitor as RV_MON_<TYPE>.
> Nothing checks it, so a typo yields a monitor that cannot build and the
> tool still exits 0:
>
>     $ rvgen monitor -c da -s test_da.dot -t bogus_type -n bm
>     $ grep RV_MON_TYPE bm/bm.c
>     #define RV_MON_TYPE RV_MON_BOGUS_TYPE
>
> include/linux/rv.h defines only RV_MON_GLOBAL, RV_MON_PER_CPU,
> RV_MON_PER_TASK and RV_MON_PER_OBJ, so that macro never resolves.
>
> The accepted set is already in Monitor.monitor_types, which the help text
> prints.  Pass it to argparse as choices.
>
> Signed-off-by: Chaosheng Qu <chaosheng.qu.linux@gmail.com>

[Severity: Low]
Monitor type validation in dot2k.__init__() was removed when
monitor_types moved to the Monitor base class in cce86e03a27f
("verification/rvgen: Restructure the classes to prepare for LTL
inclusion").  Should this include:

  Fixes: cce86e03a27f ("verification/rvgen: Restructure the classes to prepare for LTL inclusion")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1795252297.git.chaosheng.qu.linux@gmail.com?part=1

      reply	other threads:[~2026-11-21 11:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-21 11:31 [PATCH v2 0/2] verification/rvgen: validate the monitor type Chaosheng Qu
2026-11-21 11:31 ` [PATCH v2 2/2] verification/rvgen: Cover an invalid " Chaosheng Qu
2026-11-21 11:31 ` [PATCH v2 1/2] verification/rvgen: Validate the " Chaosheng Qu
2026-11-21 11:36   ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-226981@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=chaosheng.qu.linux@gmail.com \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox