From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 809A9CF6C1D for ; Wed, 7 Jan 2026 09:29:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=wk512LwmO/uZGHz1Ojwhz3Ek5WphQWvtFTpjZjwnzlQ=; b=ts+X/DVpzBCQUiDe3wXkN0ePcc YDt3+kWZLX1yh5YS14oZy3/RszOOI3JUDlBa6wFO1qgOpltKIMp9peKFlBNU1ZoC8Exd1GS5so/Dx sXSpT+Xp5D9m5uQAKcgnV1kHTJe4RtEQtKHi06CL7Jg935mV1vgnbOyy8aYVPa9ehtOYvbxtQ0iOW IUwib/MDUfE1eZ3ebZbQv33addEYvoWwXBVxR6OlMSeFbnYwzN5faRwd3AsuZfagJZSS8s+15hSGk BQ6En/djwvZ6BXzjKO0oyFGmljFit+PZ8OYpIkOOLoYaY10lnhHA3fNfzEY/XsXb9SCqtl3ppx3tW yEiatzgw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vdPqz-0000000EWve-46J9; Wed, 07 Jan 2026 09:29:21 +0000 Received: from mail-yx1-xb134.google.com ([2607:f8b0:4864:20::b134]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vdPqx-0000000EWtt-1GsM for linux-um@lists.infradead.org; Wed, 07 Jan 2026 09:29:20 +0000 Received: by mail-yx1-xb134.google.com with SMTP id 956f58d0204a3-646d9eb45afso1774958d50.2 for ; Wed, 07 Jan 2026 01:29:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767778158; x=1768382958; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=wk512LwmO/uZGHz1Ojwhz3Ek5WphQWvtFTpjZjwnzlQ=; b=ZHSqziHHXa+TQgwUEydc3ScJc70UyM03LbRO7gJv/ftOTiohyGaEsNofe4fYBSNFsr lA2JhzE1e3bJQLiJ3PhkuDiP2e0edMpAo9OrpesZ1JfxYjgX8LOXnIgIExSY/aLxCXeQ XMA+y/Gddowxx2rtobZ4bxDS+HRTd6sPJXGB4Bf8+qZRnqSj5BUU/uIWzivqA4baVwoD VP+E592YEX5d0i+cC/D/gjbkMaHycw9el25BifBFLYGNWGPaawVvZYUzSPcDiWIEvvku xamEWCGuQG4ba4qOmVY/8jbH/IxAL2GRKPLBSyJcrbjoHl8l/d+Z50f2NHvpZfD7TLjk Bgpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767778158; x=1768382958; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wk512LwmO/uZGHz1Ojwhz3Ek5WphQWvtFTpjZjwnzlQ=; b=UXlhW19AXQmaV+XtTXenUrdiar9mTcvDjDZll5I3PjVIqXJw/aOVBhksIuwaR+VSGt 8P995n3twuS9Kv6H4xDAILSf4eWUig5IxJ9oUWFqetCyAJwX1rVLWIf1+0RiXGQip5gU Irf5uBexp+6qAWP/fiBN2MAesqmd7dSMKxC/c/7iIsYRQDm642vfkV2sUalfzcIsYk6c VN/DVmp+5UIianTBnqyNgR/0oQTTDTrH1SIgIu6RH5YwUehEqvRvJmssCtFzsMRLGNmZ 4aMP0MwcZpiaRl7M66wlq9py+OiNj8sc5dqSOnrEUTzyyTmKej64O1QCIas0eVaM1IHA g42Q== X-Forwarded-Encrypted: i=1; AJvYcCVzEVM5rvmRQ+Wc5/aOua1f4D6GdxRdB4aroM8nBB/gLPKmwT4cCFDiLgzfknQe1H52eFjXSejQHw==@lists.infradead.org X-Gm-Message-State: AOJu0YyVND5QgEWDVnyZlMYf0SB/XVGjQm9Jx19sLH9qxb4u+SB1pNmF +klsiHPnFycXjXjUXiwf30UEmztQzfduFjxIUk9nFN5nWYUM9Rro1VrW X-Gm-Gg: AY/fxX5dZu/VhquL656VJ3o1DVGbRBpE8N9igDhPR44l7qJW4rnvU33GCNWYiIss0QQ ciwyfm2LBEFcfhnn0GAkqikf+YOVpP716rgHq5gPsVyTuv6eKBd6bJcPa6+mhyaqMCB2WcVRtys uYcuCCFGY4ciW2ZxyezWOscObyFRVAc9NPPHtGloOdYWqos2Xrk+mKg4O+GDVy9+r7LwcNDBFoU mSWxoOslqP6LBb28EiFPmNRFwJoWMETB4H/FbntBR7ZjJyipY8AmWdi9Pma3PGLV98A9bNq9tLJ D6me061B8346KLMzT8Yfq5r0i3f5j9TsywmHnkkqZXp6D22f6v3xdeAY/yARzIcoPQSg9tY4lgY +Zut3oG8+W34XvK94PietFrgXy+s8x9sLnInwqaRhOyje0XfyO3782O+wsJ1hpN493qflmYa1Ln 04JrpP1KU2xvTcnc7FxHeMxEw9wnLF7DZDyXvGmg== X-Google-Smtp-Source: AGHT+IGPYSkTJQTXRdeZJNO0Ptp1UF4C4ZvN+4Y+pwY9mfVj1KcuNobxA+hhEKXT47wj8D4Ny+QBYg== X-Received: by 2002:a05:690e:1483:b0:644:60d9:8654 with SMTP id 956f58d0204a3-64716c69eccmr1598952d50.87.1767778157608; Wed, 07 Jan 2026 01:29:17 -0800 (PST) Received: from [192.168.2.226] (104.194.78.75.16clouds.com. [104.194.78.75]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-6470d80be64sm1865006d50.6.2026.01.07.01.28.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 Jan 2026 01:29:16 -0800 (PST) Message-ID: <080e493a-e4f1-4c97-a3e1-f76f126b5213@gmail.com> Date: Wed, 7 Jan 2026 17:28:36 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/pgtable: convert pgtable_t to ptdesc pointer To: Mike Rapoport , alexs@kernel.org Cc: Richard Henderson , Matt Turner , Magnus Lindholm , Vineet Gupta , Russell King , Will Deacon , "Aneesh Kumar K.V" , Andrew Morton , Nick Piggin , Peter Zijlstra , Catalin Marinas , Guo Ren , Brian Cain , Huacai Chen , WANG Xuerui , Geert Uytterhoeven , Michal Simek , Thomas Bogendoerfer , Dinh Nguyen , Jonas Bonn , Stefan Kristiansson , Stafford Horne , "James E.J. Bottomley" , Helge Deller , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , Richard Weinberger , Anton Ivanov , Johannes Berg , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , "H. Peter Anvin" , Andy Lutomirski , Chris Zankel , Max Filippov , Arnd Bergmann , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , "open list:ALPHA PORT" , open list , "open list:SYNOPSYS ARC ARCHITECTURE" , "moderated list:ARM PORT" , "open list:MMU GATHER AND TLB INVALIDATION" , "open list:MMU GATHER AND TLB INVALIDATION" , "open list:C-SKY ARCHITECTURE" , "open list:QUALCOMM HEXAGON ARCHITECTURE" , "open list:LOONGARCH" , "open list:M68K ARCHITECTURE" , "open list:MIPS" , "open list:OPENRISC ARCHITECTURE" , "open list:PARISC ARCHITECTURE" , "open list:RISC-V ARCHITECTURE" , "open list:SUPERH" , "open list:USER-MODE LINUX (UML)" References: <20260107064642.15771-1-alexs@kernel.org> Content-Language: en-US From: Alex Shi In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260107_012919_347506_2A811E65 X-CRM114-Status: GOOD ( 15.78 ) X-BeenThere: linux-um@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-um" Errors-To: linux-um-bounces+linux-um=archiver.kernel.org@lists.infradead.org On 2026/1/7 17:05, Mike Rapoport wrote: > On Wed, Jan 07, 2026 at 02:46:35PM +0800,alexs@kernel.org wrote: >> From: Alex Shi >> >> After struct ptdesc introduced, pgtable_t should used it instead of old >> struct page pointer. The only thing in the way for this change is just >> pgtable->lru in pgtable_trans_huge_deposit/withdraw. >> >> Let's convert them into ptdesc and use struct ptdesc* as pgtable_t. >> Thanks testing support from kernel test robot >> >> Signed-off-by: Alex Shi >> --- > ... > >> diff --git a/arch/arm/include/asm/pgalloc.h b/arch/arm/include/asm/pgalloc.h >> index a17f01235c29..1a3484c2df4c 100644 >> --- a/arch/arm/include/asm/pgalloc.h >> +++ b/arch/arm/include/asm/pgalloc.h >> @@ -96,12 +96,12 @@ pte_alloc_one(struct mm_struct *mm) >> { >> struct page *pte; >> >> - pte = __pte_alloc_one(mm, GFP_PGTABLE_USER | PGTABLE_HIGHMEM); >> + pte = ptdesc_page(__pte_alloc_one(mm, GFP_PGTABLE_USER | PGTABLE_HIGHMEM)); > When ptdesc will be separated from struct page, ptdesc_page() would fail if the > allocation failed. This line should be split into something like > > struct ptdesc *ptdesc = __pte_alloc_one(...); > if (!ptesc) > return NULL; > pte = ptdesc_page(ptdesc); > > Right, I will fix this. and sent the 2nd version. Thanks a lot! >> if (!pte) >> return NULL; >> if (!PageHighMem(pte)) >> clean_pte_table(page_address(pte)); >> - return pte; >> + return page_ptdesc(pte); >> } >> >> static inline void __pmd_populate(pmd_t *pmdp, phys_addr_t pte, > -- Sincerely yours, Mike. >