Re: [RESEND PATCH 4/4] um: irq: don't set the chip for all irqs

From: Dana Johnson <djohns042@gmail.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>,
	Anton Ivanov <anton.ivanov@cambridgegreys.com>
Cc: Richard Weinberger <richard.weinberger@gmail.com>,
	Richard Weinberger <richard@nod.at>,
	Jeff Dike <jdike@addtoit.com>,
	linux-um@lists.infradead.org,
	Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: Re: [RESEND PATCH 4/4] um: irq: don't set the chip for all irqs
Date: Fri, 31 May 2019 03:30:16 -0700	[thread overview]
Message-ID: <0aa6028b-7b7b-4123-07a3-786f700f3c14@gmail.com> (raw)
In-Reply-To: <CAMRc=MeOHr0bKJYGgOrhHq4dYFwCnpYvuFAL3jZerwCPvQgC3Q@mail.gmail.com>

On 5/11/19 5:48 AM, Bartosz Golaszewski wrote:
> pt., 10 maj 2019 o 18:22 Anton Ivanov
> <anton.ivanov@cambridgegreys.com> napisał(a):
>>
>>
>> On 10/05/2019 17:20, Bartosz Golaszewski wrote:
>>> pt., 10 maj 2019 o 11:16 Bartosz Golaszewski <brgl@bgdev.pl> napisał(a):
>>>> śr., 8 maj 2019 o 09:13 Richard Weinberger <richard@nod.at> napisał(a):
>>>>> ----- Ursprüngliche Mail -----
>>>>>>> Can you please check?
>>>>>>> This patch is already queued in -next. So we need to decide whether to
>>>>>>> revert or fix it now.
>>>>>>>
>>>>>> I am looking at it. It passed tests in my case (I did the usual round).
>>>>> It works here too. That's why I never noticed.
>>>>> Yesterday I noticed just because I looked for something else in the kernel logs.
>>>>>
>>>>> Thanks,
>>>>> //richard
>>>> Hi,
>>>>
>>>> sorry for the late reply - I just came back from vacation.
>>>>
>>>> I see it here too, I'll check if I can find the culprit and fix it today.
>>>>
>>>> Bart
>>> Hi Richard, Anton,
>>>
>>> I'm not sure yet what this is caused by. It doesn't seem to break
>>> anything for me but since it's a new error message I guess it's best
>>> to revert this patch (others are good) and revisit it for v5.3.
>>
>> Can you send me your command line and .config so I can try to reproduce it.
>>
> 
> Sure,
> 
> the command line is:
> 
> ./linux rootfstype=hostfs rootflags=<path to a regular buildroot
> rootfs> rw mem=48M
> 
> The config is the regular x86_64_defconfig from arch/um.
> 
> Bart
> 
 
I hit this compiling 5.2.0-rc2-00024-gbec7550cca10

I can trigger:

Trying to reregister IRQ 11 FD 9 TYPE 0 ID (____ptrval____)
write_sigio_irq : um_request_irq failed, err = -16

during boot when:

# CONFIG_UML_NET_VECTOR is not set

Looking at the code there seems to be a one off error
in the LAST_IRQ calculation when CONFIG_UML_NET_VECTOR is enabled.
In that case the patch should be reverted and the following applied:

diff --git a/arch/um/include/asm/irq.h b/arch/um/include/asm/irq.h
index 49ed3e35b35a..ce7a78c3bcf2 100644
--- a/arch/um/include/asm/irq.h
+++ b/arch/um/include/asm/irq.h
@@ -23,7 +23,7 @@
 #define VECTOR_BASE_IRQ                15
 #define VECTOR_IRQ_SPACE       8

-#define LAST_IRQ (VECTOR_IRQ_SPACE + VECTOR_BASE_IRQ)
+#define LAST_IRQ (VECTOR_IRQ_SPACE + VECTOR_BASE_IRQ - 1)

 #else

Dana

_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um
