From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Date: Tue, 19 Oct 2010 12:27:26 +0200
From: Richard Weinberger <richard@nod.at>
Subject: Re: [PATCH 1/1] hostfs: fix UML crash
In-Reply-To: <20101019011125.GA3905@lst.de>
References: <1287419814-20086-1-git-send-email-richard@nod.at>
 <20101018114039.503233da.akpm@linux-foundation.org>
 <201010182053.58496.richard@nod.at>
 <20101018130208.7b552527.akpm@linux-foundation.org>
 <20101019011125.GA3905@lst.de>
Message-ID: <0ec4162fd4bfc651204532a22ac87a79@radon2.swed.at>
Sender: linux-kernel-owner@vger.kernel.org
To: Christoph Hellwig <hch@lst.de>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org, jdike@addtoit.com, user-mode-linux-devel@lists.sourceforge.net, viro@zeniv.linux.org.uk, toralf.foerster@gmx.de, Arnd Bergmann <arnd@arndb.de>
List-ID: <user-mode-linux-devel.lists.sourceforge.net>

On Tue, 19 Oct 2010 03:11:25 +0200, Christoph Hellwig <hch@lst.de>
wrote:
> On Mon, Oct 18, 2010 at 01:02:08PM -0700, Andrew Morton wrote:
>> > >
>> > > Is there any reason for hostfs to be playing with the f_spare field at all?
> 
> No, there is no reason at all.  do_statfs is only called by
> hostfs_statfs, which is the hostfs implementation of ->statfs.  zeroing
> of the spare fields is done by common code (vfs_statfs_native).

Thanks!

> Can you submit a patch to just remove the spare_out argument to do_statfs?

Sure.