linux-um archives
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: Jani Nikula <jani.nikula@intel.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
	 anton ivanov <anton.ivanov@cambridgegreys.com>,
	 linux-um <linux-um@lists.infradead.org>,
	 intel-xe@lists.freedesktop.org,
	 Lucas De Marchi <lucas.demarchi@intel.com>,
	 Tiwei Bie <tiwei.btw@antgroup.com>
Subject: Re: -Wmissing-prototypes warnings in user-mode linux
Date: Mon, 22 Apr 2024 22:35:28 +0200 (CEST)	[thread overview]
Message-ID: <1006521759.15130.1713818128220.JavaMail.zimbra@nod.at> (raw)
In-Reply-To: <87frx52btl.fsf@intel.com>

----- Ursprüngliche Mail -----
> Von: "Jani Nikula" <jani.nikula@intel.com>
> An: "Johannes Berg" <johannes@sipsolutions.net>, "richard" <richard@nod.at>, "anton ivanov"
>> I think this series addressed most already?
>>
>> https://patchwork.ozlabs.org/project/linux-um/list/?series=393619
>>
>> But I haven't checked myself yet.
> 
> Oh, nice, it certainly helps!
> 
> But after applying that in my branch, I do still get a bunch of
> warnings.

Exactly.

Tiwei Bie, with your v3 series[0] applied,
I still see the following build warnings:
arch/x86/um/signal.c:559:6: warning: no previous prototype for ‘sys_rt_sigreturn’ [-Wmissing-prototypes]
  559 | long sys_rt_sigreturn(void)
      |      ^~~~~~~~~~~~~~~~
arch/um/os-Linux/mem.c:28:6: warning: no previous prototype for ‘kasan_map_memory’ [-Wmissing-prototypes]
   28 | void kasan_map_memory(void *start, size_t len)
      |      ^~~~~~~~~~~~~~~~
arch/um/os-Linux/mem.c:212:13: warning: no previous prototype for ‘check_tmpexec’ [-Wmissing-prototypes]
  212 | void __init check_tmpexec(void)
      |             ^~~~~~~~~~~~~
arch/x86/um/os-Linux/registers.c:146:15: warning: no previous prototype for ‘get_thread_reg’ [-Wmissing-prototypes]
  146 | unsigned long get_thread_reg(int reg, jmp_buf *buf)
      |               ^~~~~~~~~~~~~~
arch/um/os-Linux/skas/process.c:107:6: warning: no previous prototype for ‘wait_stub_done’ [-Wmissing-prototypes]
  107 | void wait_stub_done(int pid)
      |      ^~~~~~~~~~~~~~
arch/um/os-Linux/skas/process.c:683:6: warning: no previous prototype for ‘__switch_mm’ [-Wmissing-prototypes]
  683 | void __switch_mm(struct mm_id *mm_idp)
      |      ^~~~~~~~~~~
arch/x86/um/vdso/um_vdso.c:16:5: warning: no previous prototype for ‘__vdso_clock_gettime’ [-Wmissing-prototypes]
   16 | int __vdso_clock_gettime(clockid_t clock, struct __kernel_old_timespec *ts)
      |     ^~~~~~~~~~~~~~~~~~~~
arch/x86/um/vdso/um_vdso.c:30:5: warning: no previous prototype for ‘__vdso_gettimeofday’ [-Wmissing-prototypes]
   30 | int __vdso_gettimeofday(struct __kernel_old_timeval *tv, struct timezone *tz)
      |     ^~~~~~~~~~~~~~~~~~~
arch/x86/um/vdso/um_vdso.c:44:21: warning: no previous prototype for ‘__vdso_time’ [-Wmissing-prototypes]
   44 | __kernel_old_time_t __vdso_time(__kernel_old_time_t *t)
      |                     ^~~~~~~~~~~
arch/x86/um/vdso/um_vdso.c:57:1: warning: no previous prototype for ‘__vdso_getcpu’ [-Wmissing-prototypes]
   57 | __vdso_getcpu(unsigned *cpu, unsigned *node, struct getcpu_cache *unused)
      | ^~~~~~~~~~~~~

[0] https://patchwork.ozlabs.org/project/linux-um/list/?series=397986

Thanks,
//richard


  parent reply	other threads:[~2024-04-22 20:35 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-05 10:34 -Wmissing-prototypes warnings in user-mode linux Jani Nikula
2024-03-05 10:35 ` Johannes Berg
2024-03-05 10:49   ` Jani Nikula
2024-03-05 11:17     ` Johannes Berg
2024-03-05 11:18     ` Tiwei Bie
2024-03-05 13:45       ` Jani Nikula
2024-03-05 14:26         ` Tiwei Bie
2024-04-22 20:35     ` Richard Weinberger [this message]
2024-04-23  4:59       ` Tiwei Bie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1006521759.15130.1713818128220.JavaMail.zimbra@nod.at \
    --to=richard@nod.at \
    --cc=anton.ivanov@cambridgegreys.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-um@lists.infradead.org \
    --cc=lucas.demarchi@intel.com \
    --cc=tiwei.btw@antgroup.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox