From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sc8-sf-mx1-b.sourceforge.net ([10.3.1.11] helo=sc8-sf-mx1.sourceforge.net) by sc8-sf-list1.sourceforge.net with esmtp (Exim 4.30) id 1D9ImE-0008Ba-QL for user-mode-linux-devel@lists.sourceforge.net; Thu, 10 Mar 2005 00:12:14 -0800 Received: from 213-239-205-147.clients.your-server.de ([213.239.205.147] helo=mail.tglx.de) by sc8-sf-mx1.sourceforge.net with esmtp (Exim 4.41) id 1D9ImD-0008Tj-9N for user-mode-linux-devel@lists.sourceforge.net; Thu, 10 Mar 2005 00:12:14 -0800 From: Thomas Gleixner Reply-To: tglx@linutronix.de In-Reply-To: <200503092052.24803.blaisorblade@yahoo.it> References: <20050309094234.8FC0C6477@zion> <20050309171231.H25398@flint.arm.linux.org.uk> <200503092052.24803.blaisorblade@yahoo.it> Content-Type: text/plain Message-Id: <1110442320.29330.196.camel@tglx.tec.linutronix.de> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [uml-devel] Re: [patch 1/1] unified spinlock initialization arch/um/drivers/port_kern.c Sender: user-mode-linux-devel-admin@lists.sourceforge.net Errors-To: user-mode-linux-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Id: The user-mode Linux development list List-Post: List-Help: List-Subscribe: , List-Archive: Date: Thu, 10 Mar 2005 09:12:00 +0100 To: Blaisorblade Cc: Russell King , Andrew Morton , LKML , user-mode-linux-devel@lists.sourceforge.net, domen@coderock.org, amitg@calsoftinc.com, gud@eth.net On Wed, 2005-03-09 at 20:52 +0100, Blaisorblade wrote: > > Are you sure this is really the best option in this instance? > > Sometimes, static data initialisation is more efficient than > > code-based manual initialisation, especially when the memory > > is written to anyway. > Agreed, theoretically, but this was done for multiple reasons globally, for > instance as a preparation to Ingo Molnar's preemption patches. There was > mention of this on lwn.net about this: > > http://lwn.net/Articles/108719/ Those patches did only the conversion of static spinlock_t lock = SPIN_LOCK_UNLOCKED; lock = SPIN_LOCK_UNLOCKED; to static DEFINE_SPINLOCK(lock); spin_lock_init(lock); If you want to do static initialization inside of structures, then you have to define a seperate MACRO similar to the static initialization of list_head's inside of structures: static struct sysfs_dirent sysfs_root = { .s_sibling = LIST_HEAD_INIT(sysfs_root.s_sibling), tglx ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click _______________________________________________ User-mode-linux-devel mailing list User-mode-linux-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel