From: Steven Rostedt <rostedt@goodmis.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
richard -rw- weinberger <richard.weinberger@gmail.com>,
laijs@cn.fujitsu.com, LKML <linux-kernel@vger.kernel.org>,
user-mode-linux-devel@lists.sourceforge.net,
dvhart@linux.intel.com
Subject: Re: um: WARNING: at kernel/futex.c:786 __unqueue_futex
Date: Thu, 17 Mar 2011 14:32:50 -0400 [thread overview]
Message-ID: <1300386770.16880.383.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <1300386121.16880.359.camel@gandalf.stny.rr.com>
On Thu, 2011-03-17 at 14:22 -0400, Steven Rostedt wrote:
> On Thu, 2011-03-17 at 18:43 +0100, Geert Uytterhoeven wrote:
>
> > I don't know. It's not clear to me if "WARN_ON_SMP(x)" should always return "x",
> > or only on SMP?
> >
> > E.g.
> >
> > if (WARN_ON_SMP(x)) {
> > // Should we get here if "x" is true?
> > // Or only if CONFIG_SMP and "x" are both true?
> > }
> >
>
> The "Or only if CONFIG_SMP and "x" are both true.
>
> I'll update the change to add a comment about that.
>
We are the first user of this false return, as do { } while (0) doesn't
return anything. I'll add a comment to explain the issue, but it makes
sense to have it returns false on UNIPROCESSOR.
-- Steve
next prev parent reply other threads:[~2011-03-17 18:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-17 12:25 um: WARNING: at kernel/futex.c:786 __unqueue_futex richard -rw- weinberger
2011-03-17 14:08 ` Steven Rostedt
2011-03-17 14:17 ` richard -rw- weinberger
2011-03-17 14:27 ` richard -rw- weinberger
2011-03-17 14:31 ` Steven Rostedt
2011-03-17 16:55 ` Steven Rostedt
2011-03-17 17:02 ` Eric Dumazet
2011-03-17 17:43 ` Geert Uytterhoeven
2011-03-17 18:22 ` Steven Rostedt
2011-03-17 18:32 ` Steven Rostedt [this message]
2011-03-17 18:16 ` Steven Rostedt
2011-03-17 18:25 ` Geert Uytterhoeven
2011-03-17 18:38 ` Steven Rostedt
2011-03-17 18:38 ` Eric Dumazet
2011-03-17 18:43 ` Steven Rostedt
2011-03-17 17:18 ` richard -rw- weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1300386770.16880.383.camel@gandalf.stny.rr.com \
--to=rostedt@goodmis.org \
--cc=dvhart@linux.intel.com \
--cc=eric.dumazet@gmail.com \
--cc=geert@linux-m68k.org \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=richard.weinberger@gmail.com \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox