From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <1332607407.16159.51.camel@twins> From: Peter Zijlstra Date: Sat, 24 Mar 2012 17:43:27 +0100 In-Reply-To: <20120324162151.GA3640@lizard> References: <20120324102609.GA28356@lizard> <20120324103127.GJ29067@lizard> <1332593574.16159.31.camel@twins> <20120324162151.GA3640@lizard> Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Subject: Re: [PATCH 10/10] oom: Make find_lock_task_mm() sparse-aware To: Anton Vorontsov Cc: Andrew Morton , Oleg Nesterov , Russell King , Mike Frysinger , Benjamin Herrenschmidt , Richard Weinberger , Paul Mundt , KOSAKI Motohiro , John Stultz , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, uclinux-dist-devel@blackfin.uclinux.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, user-mode-linux-devel@lists.sourceforge.net, linux-mm@kvack.org, Linus Torvalds List-ID: On Sat, 2012-03-24 at 20:21 +0400, Anton Vorontsov wrote: > Just wonder how do you see the feature implemented? > > Something like this? > > #define __ret_cond_locked(l, c) __attribute__((ret_cond_locked(l, c))) > #define __ret_value __attribute__((ret_value)) > #define __ret_locked_nonnull(l) __ret_cond_locked(l, __ret_value); > > extern struct task_struct *find_lock_task_mm(struct task_struct *p) > __ret_locked_nonnull(&__ret_value->alloc_lock); Yeah, see the email I just CC'ed you on to linux-sparse. Basically extend __attribute__((context())) to allow things similar to what you proposed.