From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <1355422990.13796.9.camel@joe-AO722> From: Joe Perches Date: Thu, 13 Dec 2012 10:23:10 -0800 In-Reply-To: <20121212224550.GJ8760@liondog.tnic> References: <054f8a88fe46ae0b4c2669d0e155d84c11b66115.1355335228.git.joe@perches.com> <20121212210959.GH8760@liondog.tnic> <1355347803.8538.16.camel@joe-AO722> <3908561D78D1C84285E8C5FCA982C28F1C969495@ORSMSX108.amr.corp.intel.com> <1355351039.27571.2.camel@joe-AO722> <20121212224550.GJ8760@liondog.tnic> Content-Type: text/plain; charset=UTF-8 Mime-Version: 1.0 Content-Transfer-Encoding: QUOTED-PRINTABLE Sender: linux-kernel-owner@vger.kernel.org Subject: Re: [TRIVIAL PATCH 16/26] x86: Convert print_symbol to %pSR To: Borislav Petkov Cc: "Luck, Tony" , Jiri Kosina , Jeff Dike , Richard Weinberger , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , "x86@kernel.org" , "linux-edac@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "user-mode-linux-devel@lists.sourceforge.net" , "user-mode-linux-user@lists.sourceforge.net" List-ID: On Wed, 2012-12-12 at 23:45 +0100, Borislav Petkov wrote: > On Wed, Dec 12, 2012 at 02:23:59PM -0800, Joe Perches wrote: > > On Wed, 2012-12-12 at 21:49 +0000, Luck, Tony wrote: > > > > I think I'd go ahead and ACK this unless Tony has some comments= =2E I'm not > > > > happy about the two pr_emerg calls based on the conditional. > > >=20 > > > As written the patch has the nice property of not making any chan= ges to the > > > console output (except to eliminate the possibility of interleave= d output that > > > the original code had). > >=20 > > Well, it does eliminate a trailing space when m->cs !=3D KERNEL_CS. > > That probably won't hurt anything, but... >=20 > Yeah, that won't be an issue. So let's take it as is, as Tony suggest= s. Hi again Boris. I should mention one more thing. m->ip is a u64 so, when compiling x86-32, there's a new warning "cast to pointer from integer of different size". This isn't new different behavior, just a new warning. The previous print_symbol took a ulong and the u64 was silently truncated. CC arch/x86/kernel/cpu/mcheck/mce.o arch/x86/kernel/cpu/mcheck/mce.c: In function =E2=80=98print_mce=E2=80=99= : arch/x86/kernel/cpu/mcheck/mce.c:246:4: warning: cast to pointer from i= nteger of different size [-Wint-to-pointer-cast] If appropriate, the code could be changed to (void *)(unsigned long)m->ip to shut the compiler up. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel"= in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/