* Re: linux-next: Tree for Jul 16 (drivers/vfio/cdx/intr.c)
[not found] <20250716212558.4dd0502b@canb.auug.org.au>
@ 2025-07-16 23:07 ` Randy Dunlap
2025-07-17 6:52 ` Krzysztof Kozlowski
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2025-07-16 23:07 UTC (permalink / raw)
To: Stephen Rothwell, Linux Next Mailing List
Cc: Linux Kernel Mailing List, linux-um, Linux KVM, Nipun Gupta,
Nikhil Agarwal, Krzysztof Kozlowski
On 7/16/25 4:25 AM, Stephen Rothwell wrote:
> Hi all,
>
> Changes since 20250715:
>
on ARCH=um SUBARCH=x86_64:
../drivers/vfio/cdx/intr.c: In function ‘vfio_cdx_msi_enable’:
../drivers/vfio/cdx/intr.c:41:15: error: implicit declaration of function ‘msi_domain_alloc_irqs’; did you mean ‘msi_domain_get_virq’? [-Wimplicit-function-declaration]
41 | ret = msi_domain_alloc_irqs(dev, MSI_DEFAULT_DOMAIN, nvec);
| ^~~~~~~~~~~~~~~~~~~~~
| msi_domain_get_virq
../drivers/vfio/cdx/intr.c: In function ‘vfio_cdx_msi_disable’:
../drivers/vfio/cdx/intr.c:135:9: error: implicit declaration of function ‘msi_domain_free_irqs_all’ [-Wimplicit-function-declaration]
135 | msi_domain_free_irqs_all(dev, MSI_DEFAULT_DOMAIN);
| ^~~~~~~~~~~~~~~~~~~~~~~~
Those missing functions are provided by CONFIG_GENERIC_MSI_IRQ
(which is not set).
Should VFIO_CDX select GENERIC_MSI_IRQ or just not build on ARCH=um?
--
~Randy
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: linux-next: Tree for Jul 16 (drivers/vfio/cdx/intr.c)
2025-07-16 23:07 ` linux-next: Tree for Jul 16 (drivers/vfio/cdx/intr.c) Randy Dunlap
@ 2025-07-17 6:52 ` Krzysztof Kozlowski
0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2025-07-17 6:52 UTC (permalink / raw)
To: Randy Dunlap, Stephen Rothwell, Linux Next Mailing List
Cc: Linux Kernel Mailing List, linux-um, Linux KVM, Nipun Gupta,
Nikhil Agarwal
On 17/07/2025 01:07, Randy Dunlap wrote:
>
>
> On 7/16/25 4:25 AM, Stephen Rothwell wrote:
>> Hi all,
>>
>> Changes since 20250715:
>>
>
> on ARCH=um SUBARCH=x86_64:
>
> ../drivers/vfio/cdx/intr.c: In function ‘vfio_cdx_msi_enable’:
> ../drivers/vfio/cdx/intr.c:41:15: error: implicit declaration of function ‘msi_domain_alloc_irqs’; did you mean ‘msi_domain_get_virq’? [-Wimplicit-function-declaration]
> 41 | ret = msi_domain_alloc_irqs(dev, MSI_DEFAULT_DOMAIN, nvec);
> | ^~~~~~~~~~~~~~~~~~~~~
> | msi_domain_get_virq
> ../drivers/vfio/cdx/intr.c: In function ‘vfio_cdx_msi_disable’:
> ../drivers/vfio/cdx/intr.c:135:9: error: implicit declaration of function ‘msi_domain_free_irqs_all’ [-Wimplicit-function-declaration]
> 135 | msi_domain_free_irqs_all(dev, MSI_DEFAULT_DOMAIN);
> | ^~~~~~~~~~~~~~~~~~~~~~~~
>
>
> Those missing functions are provided by CONFIG_GENERIC_MSI_IRQ
> (which is not set).
>
> Should VFIO_CDX select GENERIC_MSI_IRQ or just not build on ARCH=um?
I think this will be also resolved with my change to select
GENERIC_MSI_IRQ by CDX_BUS, but to be fair, I think that VFIO_CDX should
also select GENERIC_MSI_IRQ. My reasoning is that:
1. GENERIC_MSI_IRQ is non-user selectable, thus it is supposed to be
selected by Kconfig entries
2. Every explicit user of a code should select such symbol, not rely on
someone else selecting it.
I will send a patch proposing this.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-07-17 6:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20250716212558.4dd0502b@canb.auug.org.au>
2025-07-16 23:07 ` linux-next: Tree for Jul 16 (drivers/vfio/cdx/intr.c) Randy Dunlap
2025-07-17 6:52 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).