From: Richard Weinberger <richard@nod.at>
To: hch <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>,
anton ivanov <anton.ivanov@cambridgegreys.com>,
Josef Bacik <josef@toxicpanda.com>,
Minchan Kim <minchan@kernel.org>,
senozhatsky <senozhatsky@chromium.org>, Coly Li <colyli@suse.de>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Vignesh Raghavendra <vigneshr@ti.com>,
linux-um <linux-um@lists.infradead.org>,
linux-block <linux-block@vger.kernel.org>,
nbd@other.debian.org,
linux-bcache <linux-bcache@vger.kernel.org>,
linux-mtd <linux-mtd@lists.infradead.org>
Subject: Re: [PATCH 4/9] ubd: use the default discard granularity
Date: Thu, 28 Dec 2023 12:10:11 +0100 (CET) [thread overview]
Message-ID: <1544995699.172154.1703761811676.JavaMail.zimbra@nod.at> (raw)
In-Reply-To: <20231228075545.362768-5-hch@lst.de>
----- Ursprüngliche Mail -----
> Von: "hch" <hch@lst.de>
> An: "Jens Axboe" <axboe@kernel.dk>
> CC: "richard" <richard@nod.at>, "anton ivanov" <anton.ivanov@cambridgegreys.com>, "Josef Bacik" <josef@toxicpanda.com>,
> "Minchan Kim" <minchan@kernel.org>, "senozhatsky" <senozhatsky@chromium.org>, "Coly Li" <colyli@suse.de>, "Miquel
> Raynal" <miquel.raynal@bootlin.com>, "Vignesh Raghavendra" <vigneshr@ti.com>, "linux-um"
> <linux-um@lists.infradead.org>, "linux-block" <linux-block@vger.kernel.org>, nbd@other.debian.org, "linux-bcache"
> <linux-bcache@vger.kernel.org>, "linux-mtd" <linux-mtd@lists.infradead.org>
> Gesendet: Donnerstag, 28. Dezember 2023 08:55:40
> Betreff: [PATCH 4/9] ubd: use the default discard granularity
> The discard granularity now defaults to a single sector, so don't set
> that value explicitly.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> arch/um/drivers/ubd_kern.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/um/drivers/ubd_kern.c b/arch/um/drivers/ubd_kern.c
> index 50206feac577d5..92ee2697ff3984 100644
> --- a/arch/um/drivers/ubd_kern.c
> +++ b/arch/um/drivers/ubd_kern.c
> @@ -798,7 +798,6 @@ static int ubd_open_dev(struct ubd *ubd_dev)
> ubd_dev->cow.fd = err;
> }
> if (ubd_dev->no_trim == 0) {
> - ubd_dev->queue->limits.discard_granularity = SECTOR_SIZE;
> blk_queue_max_discard_sectors(ubd_dev->queue, UBD_MAX_REQUEST);
> blk_queue_max_write_zeroes_sectors(ubd_dev->queue, UBD_MAX_REQUEST);
> }
Acked-by: Richard Weinberger <richard@nod.at>
Thanks,
//richard
next prev parent reply other threads:[~2023-12-28 11:10 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-28 7:55 provide a sane discard_granularity default Christoph Hellwig
2023-12-28 7:55 ` [PATCH 1/9] block: remove two comments in bio_split_discard Christoph Hellwig
2023-12-28 7:55 ` [PATCH 2/9] bcache: discard_granularity should not be smaller than a sector Christoph Hellwig
2023-12-28 7:55 ` [PATCH 3/9] block: default the discard granularity to sector size Christoph Hellwig
2024-01-02 22:11 ` John Pittman
2024-01-03 7:57 ` Christoph Hellwig
2023-12-28 7:55 ` [PATCH 4/9] ubd: use the default discard granularity Christoph Hellwig
2023-12-28 11:10 ` Richard Weinberger [this message]
2023-12-28 7:55 ` [PATCH 5/9] nbd: " Christoph Hellwig
2023-12-28 7:55 ` [PATCH 6/9] null_blk: " Christoph Hellwig
2023-12-28 7:55 ` [PATCH 7/9] zram: " Christoph Hellwig
2024-01-02 1:15 ` Sergey Senozhatsky
2024-01-02 15:40 ` Jens Axboe
2024-01-02 15:44 ` Jens Axboe
2024-01-02 15:47 ` Jens Axboe
2024-01-06 1:32 ` Sergey Senozhatsky
2023-12-28 7:55 ` [PATCH 8/9] bcache: " Christoph Hellwig
2024-01-05 7:03 ` Coly Li
2023-12-28 7:55 ` [PATCH 9/9] mtd_blkdevs: " Christoph Hellwig
2023-12-28 11:09 ` Richard Weinberger
2023-12-29 15:44 ` provide a sane discard_granularity default Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1544995699.172154.1703761811676.JavaMail.zimbra@nod.at \
--to=richard@nod.at \
--cc=anton.ivanov@cambridgegreys.com \
--cc=axboe@kernel.dk \
--cc=colyli@suse.de \
--cc=hch@lst.de \
--cc=josef@toxicpanda.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-um@lists.infradead.org \
--cc=minchan@kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=nbd@other.debian.org \
--cc=senozhatsky@chromium.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).