From: Richard Weinberger <richard@nod.at>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: linux-um <linux-um@lists.infradead.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH] hostfs: fix string handling in __dentry_name()
Date: Sun, 19 Jan 2025 14:36:16 +0100 (CET) [thread overview]
Message-ID: <1595202043.249250399.1737293776824.JavaMail.zimbra@nod.at> (raw)
In-Reply-To: <20250117230913.GS1977892@ZenIV>
----- Ursprüngliche Mail -----
> Von: "Al Viro" <viro@zeniv.linux.org.uk>
> An: "richard" <richard@nod.at>
> CC: "linux-um" <linux-um@lists.infradead.org>, "linux-fsdevel" <linux-fsdevel@vger.kernel.org>
> Gesendet: Samstag, 18. Januar 2025 00:09:13
> Betreff: [PATCH] hostfs: fix string handling in __dentry_name()
> [in viro/vfs.git#fixes, going to Linus unless anyone objects]
>
> strcpy() should not be used with destination potentially overlapping
> the source; what's more, strscpy() in there is pointless - we already
> know the amount we want to copy; might as well use memcpy().
>
> Fixes: c278e81b8a02 "hostfs: Remove open coded strcpy()"
Hmm, AFAICT the open coded strcpy() was also never safe wrt. overlapping strings.
Beside of that:
Acked-by: Richard Weinberger <richard@nod.at>
Thanks,
//richard
prev parent reply other threads:[~2025-01-19 13:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-17 23:09 [PATCH] hostfs: fix string handling in __dentry_name() Al Viro
2025-01-19 13:36 ` Richard Weinberger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1595202043.249250399.1737293776824.JavaMail.zimbra@nod.at \
--to=richard@nod.at \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).