From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out30-56.freemail.mail.aliyun.com ([115.124.30.56]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1neWrx-00HICm-32 for linux-um@lists.infradead.org; Wed, 13 Apr 2022 06:52:50 +0000 Message-ID: <1649832486.146921-7-xuanzhuo@linux.alibaba.com> Subject: Re: [PATCH v9 07/32] virtio_ring: split: extract the logic of alloc state and extra Date: Wed, 13 Apr 2022 14:48:06 +0800 From: Xuan Zhuo References: <20220406034346.74409-1-xuanzhuo@linux.alibaba.com> <20220406034346.74409-8-xuanzhuo@linux.alibaba.com> <927ee895-84ae-fb69-c9ed-9c1836ff1d03@redhat.com> In-Reply-To: <927ee895-84ae-fb69-c9ed-9c1836ff1d03@redhat.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: Jason Wang Cc: Jeff Dike , Richard Weinberger , Anton Ivanov , "Michael S. Tsirkin" , "David S. Miller" , Jakub Kicinski , Hans de Goede , Mark Gross , Vadim Pasternak , Bjorn Andersson , Mathieu Poirier , Cornelia Huck , Halil Pasic , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Alexander Gordeev , Sven Schnelle , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Johannes Berg , Vincent Whitchurch , linux-um@lists.infradead.org, netdev@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, kvm@vger.kernel.org, bpf@vger.kernel.org, virtualization@lists.linux-foundation.org T24gVHVlLCAxMiBBcHIgMjAyMiAxMToyNjo0OSArMDgwMCwgSmFzb24gV2FuZyA8amFzb3dhbmdA cmVkaGF0LmNvbT4gd3JvdGU6Cj4KPiDlnKggMjAyMi80LzYg5LiK5Y2IMTE6NDMsIFh1YW4gWmh1 byDlhpnpgZM6Cj4gPiBTZXBhcmF0ZSB0aGUgbG9naWMgb2YgY3JlYXRpbmcgZGVzY19zdGF0ZSwg ZGVzY19leHRyYSwgYW5kIHN1YnNlcXVlbnQKPiA+IHBhdGNoZXMgd2lsbCBjYWxsIGl0IGluZGVw ZW5kZW50bHkuCj4gPgo+ID4gU2lnbmVkLW9mZi1ieTogWHVhbiBaaHVvIDx4dWFuemh1b0BsaW51 eC5hbGliYWJhLmNvbT4KPiA+IC0tLQo+ID4gICBkcml2ZXJzL3ZpcnRpby92aXJ0aW9fcmluZy5j IHwgNTMgKysrKysrKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tCj4gPiAgIDEgZmlsZSBj aGFuZ2VkLCAzOCBpbnNlcnRpb25zKCspLCAxNSBkZWxldGlvbnMoLSkKPiA+Cj4gPiBkaWZmIC0t Z2l0IGEvZHJpdmVycy92aXJ0aW8vdmlydGlvX3JpbmcuYyBiL2RyaXZlcnMvdmlydGlvL3ZpcnRp b19yaW5nLmMKPiA+IGluZGV4IDcyZDVhZTA2M2ZhMC4uNmRlNjc0MzljYjU3IDEwMDY0NAo+ID4g LS0tIGEvZHJpdmVycy92aXJ0aW8vdmlydGlvX3JpbmcuYwo+ID4gKysrIGIvZHJpdmVycy92aXJ0 aW8vdmlydGlvX3JpbmcuYwo+ID4gQEAgLTE5OCw2ICsxOTgsNyBAQCBzdHJ1Y3QgdnJpbmdfdmly dHF1ZXVlIHsKPiA+ICAgI2VuZGlmCj4gPiAgIH07Cj4gPgo+ID4gK3N0YXRpYyBzdHJ1Y3QgdnJp bmdfZGVzY19leHRyYSAqdnJpbmdfYWxsb2NfZGVzY19leHRyYSh1bnNpZ25lZCBpbnQgbnVtKTsK PiA+Cj4gPiAgIC8qCj4gPiAgICAqIEhlbHBlcnMuCj4gPiBAQCAtOTE1LDYgKzkxNiwzMyBAQCBz dGF0aWMgdm9pZCAqdmlydHF1ZXVlX2RldGFjaF91bnVzZWRfYnVmX3NwbGl0KHN0cnVjdCB2aXJ0 cXVldWUgKl92cSkKPiA+ICAgCXJldHVybiBOVUxMOwo+ID4gICB9Cj4gPgo+ID4gK3N0YXRpYyBp bnQgdnJpbmdfYWxsb2Nfc3RhdGVfZXh0cmFfc3BsaXQodTMyIG51bSwKPiA+ICsJCQkJCSBzdHJ1 Y3QgdnJpbmdfZGVzY19zdGF0ZV9zcGxpdCAqKmRlc2Nfc3RhdGUsCj4gPiArCQkJCQkgc3RydWN0 IHZyaW5nX2Rlc2NfZXh0cmEgKipkZXNjX2V4dHJhKQo+ID4gK3sKPiA+ICsJc3RydWN0IHZyaW5n X2Rlc2Nfc3RhdGVfc3BsaXQgKnN0YXRlOwo+ID4gKwlzdHJ1Y3QgdnJpbmdfZGVzY19leHRyYSAq ZXh0cmE7Cj4gPiArCj4gPiArCXN0YXRlID0ga21hbGxvY19hcnJheShudW0sIHNpemVvZihzdHJ1 Y3QgdnJpbmdfZGVzY19zdGF0ZV9zcGxpdCksIEdGUF9LRVJORUwpOwo+ID4gKwlpZiAoIXN0YXRl KQo+ID4gKwkJZ290byBlcnJfc3RhdGU7Cj4gPiArCj4gPiArCWV4dHJhID0gdnJpbmdfYWxsb2Nf ZGVzY19leHRyYShudW0pOwo+ID4gKwlpZiAoIWV4dHJhKQo+ID4gKwkJZ290byBlcnJfZXh0cmE7 Cj4gPiArCj4gPiArCW1lbXNldChzdGF0ZSwgMCwgbnVtICogc2l6ZW9mKHN0cnVjdCB2cmluZ19k ZXNjX3N0YXRlX3NwbGl0KSk7Cj4gPiArCj4gPiArCSpkZXNjX3N0YXRlID0gc3RhdGU7Cj4gPiAr CSpkZXNjX2V4dHJhID0gZXh0cmE7Cj4gPiArCXJldHVybiAwOwo+ID4gKwo+ID4gK2Vycl9leHRy YToKPiA+ICsJa2ZyZWUoc3RhdGUpOwo+ID4gK2Vycl9zdGF0ZToKPiA+ICsJcmV0dXJuIC1FTk9N RU07Cj4gPiArfQo+ID4gKwo+ID4gICBzdGF0aWMgdm9pZCAqdnJpbmdfYWxsb2NfcXVldWVfc3Bs aXQoc3RydWN0IHZpcnRpb19kZXZpY2UgKnZkZXYsCj4gPiAgIAkJCQkgICAgIGRtYV9hZGRyX3Qg KmRtYV9hZGRyLAo+ID4gICAJCQkJICAgICB1MzIgKm4sCj4gPiBAQCAtMjE5Niw3ICsyMjI0LDEw IEBAIHN0cnVjdCB2aXJ0cXVldWUgKl9fdnJpbmdfbmV3X3ZpcnRxdWV1ZSh1bnNpZ25lZCBpbnQg aW5kZXgsCj4gPiAgIAkJCQkJdm9pZCAoKmNhbGxiYWNrKShzdHJ1Y3QgdmlydHF1ZXVlICopLAo+ ID4gICAJCQkJCWNvbnN0IGNoYXIgKm5hbWUpCj4gPiAgIHsKPiA+ICsJc3RydWN0IHZyaW5nX2Rl c2Nfc3RhdGVfc3BsaXQgKnN0YXRlOwo+ID4gKwlzdHJ1Y3QgdnJpbmdfZGVzY19leHRyYSAqZXh0 cmE7Cj4gPiAgIAlzdHJ1Y3QgdnJpbmdfdmlydHF1ZXVlICp2cTsKPiA+ICsJaW50IGVycjsKPiA+ Cj4gPiAgIAlpZiAodmlydGlvX2hhc19mZWF0dXJlKHZkZXYsIFZJUlRJT19GX1JJTkdfUEFDS0VE KSkKPiA+ICAgCQlyZXR1cm4gTlVMTDsKPiA+IEBAIC0yMjQ2LDMwICsyMjc3LDIyIEBAIHN0cnVj dCB2aXJ0cXVldWUgKl9fdnJpbmdfbmV3X3ZpcnRxdWV1ZSh1bnNpZ25lZCBpbnQgaW5kZXgsCj4g PiAgIAkJCQkJdnEtPnNwbGl0LmF2YWlsX2ZsYWdzX3NoYWRvdyk7Cj4gPiAgIAl9Cj4gPgo+ID4g LQl2cS0+c3BsaXQuZGVzY19zdGF0ZSA9IGttYWxsb2NfYXJyYXkodnJpbmcubnVtLAo+ID4gLQkJ CXNpemVvZihzdHJ1Y3QgdnJpbmdfZGVzY19zdGF0ZV9zcGxpdCksIEdGUF9LRVJORUwpOwo+ID4g LQlpZiAoIXZxLT5zcGxpdC5kZXNjX3N0YXRlKQo+ID4gLQkJZ290byBlcnJfc3RhdGU7Cj4gPiAr CWVyciA9IHZyaW5nX2FsbG9jX3N0YXRlX2V4dHJhX3NwbGl0KHZyaW5nLm51bSwgJnN0YXRlLCAm ZXh0cmEpOwo+Cj4KPiBOaXQ6IHdlIGNhbiBwYXNzIGUuZyAmdnEtPnNwbGl0LmRlc2Nfc3RhdGUg aGVyZSB0byBhdm9pZCBleHRyYSB0ZW1wCj4gdmFyaWFibGUgYW5kIGFzc2lnbm1lbnQuCgpUaGUg cmVhc29uIGZvciBub3QgZG9pbmcgdGhpcyBpcyB0aGF0IHdoZW4gd2UgaW1wbGVtZW50IHJlc2l6 ZSBsYXRlciwgd2hlbiB3ZQpjYWxsIHZyaW5nX2FsbG9jX3N0YXRlX2V4dHJhX3NwbGl0KCksIHdl IHdhbnQgdG8ga2VlcCB0aGUgb2xkIGRlc2Nfc3RhdGUsIGFuZApkZXNjX2V4dHJhIGJlY2F1c2Ug d2Ugd2FudCB0byByZWxlYXNlIHRoZW0uCgpBcyBkaXNjdXNzZWQgaW4gcGF0Y2ggMTEsIDEyLCBz dHJ1Y3QgdnJpbmdfdmlydHF1ZXVlX3NwbGl0IHdpbGwgb3B0aW1pemUgdGhpcwpsb2dpYy4KClRo YW5rcy4KCj4KPiBPdGhlciBsb29rcyBnb29kLgo+Cj4gVGhhbmtzCj4KPgo+ID4gKwlpZiAoZXJy KSB7Cj4gPiArCQlrZnJlZSh2cSk7Cj4gPiArCQlyZXR1cm4gTlVMTDsKPiA+ICsJfQo+ID4KPiA+ IC0JdnEtPnNwbGl0LmRlc2NfZXh0cmEgPSB2cmluZ19hbGxvY19kZXNjX2V4dHJhKHZyaW5nLm51 bSk7Cj4gPiAtCWlmICghdnEtPnNwbGl0LmRlc2NfZXh0cmEpCj4gPiAtCQlnb3RvIGVycl9leHRy YTsKPiA+ICsJdnEtPnNwbGl0LmRlc2Nfc3RhdGUgPSBzdGF0ZTsKPiA+ICsJdnEtPnNwbGl0LmRl c2NfZXh0cmEgPSBleHRyYTsKPiA+Cj4gPiAgIAkvKiBQdXQgZXZlcnl0aGluZyBpbiBmcmVlIGxp c3RzLiAqLwo+ID4gICAJdnEtPmZyZWVfaGVhZCA9IDA7Cj4gPiAtCW1lbXNldCh2cS0+c3BsaXQu ZGVzY19zdGF0ZSwgMCwgdnJpbmcubnVtICoKPiA+IC0JCQlzaXplb2Yoc3RydWN0IHZyaW5nX2Rl c2Nfc3RhdGVfc3BsaXQpKTsKPiA+Cj4gPiAgIAlzcGluX2xvY2soJnZkZXYtPnZxc19saXN0X2xv Y2spOwo+ID4gICAJbGlzdF9hZGRfdGFpbCgmdnEtPnZxLmxpc3QsICZ2ZGV2LT52cXMpOwo+ID4g ICAJc3Bpbl91bmxvY2soJnZkZXYtPnZxc19saXN0X2xvY2spOwo+ID4gICAJcmV0dXJuICZ2cS0+ dnE7Cj4gPiAtCj4gPiAtZXJyX2V4dHJhOgo+ID4gLQlrZnJlZSh2cS0+c3BsaXQuZGVzY19zdGF0 ZSk7Cj4gPiAtZXJyX3N0YXRlOgo+ID4gLQlrZnJlZSh2cSk7Cj4gPiAtCXJldHVybiBOVUxMOwo+ ID4gICB9Cj4gPiAgIEVYUE9SVF9TWU1CT0xfR1BMKF9fdnJpbmdfbmV3X3ZpcnRxdWV1ZSk7Cj4g Pgo+CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51 eC11bSBtYWlsaW5nIGxpc3QKbGludXgtdW1AbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlz dHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXVtCg==