From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out30-132.freemail.mail.aliyun.com ([115.124.30.132]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o7CIl-003hgp-P3 for linux-um@lists.infradead.org; Fri, 01 Jul 2022 08:47:02 +0000 Message-ID: <1656665158.0036178-3-xuanzhuo@linux.alibaba.com> Subject: Re: [PATCH v11 08/40] virtio_ring: split: extract the logic of alloc queue Date: Fri, 1 Jul 2022 16:45:58 +0800 From: Xuan Zhuo References: <20220629065656.54420-1-xuanzhuo@linux.alibaba.com> <20220629065656.54420-9-xuanzhuo@linux.alibaba.com> <3e36e44f-1f37-ad02-eb89-833a0856ec4e@redhat.com> In-Reply-To: <3e36e44f-1f37-ad02-eb89-833a0856ec4e@redhat.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: Jason Wang Cc: Richard Weinberger , Anton Ivanov , Johannes Berg , "Michael S. Tsirkin" , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Hans de Goede , Mark Gross , Vadim Pasternak , Bjorn Andersson , Mathieu Poirier , Cornelia Huck , Halil Pasic , Eric Farman , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Vincent Whitchurch , linux-um@lists.infradead.org, netdev@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, kvm@vger.kernel.org, bpf@vger.kernel.org, kangjie.xu@linux.alibaba.com, virtualization@lists.linux-foundation.org T24gRnJpLCAxIEp1bCAyMDIyIDE2OjI2OjI1ICswODAwLCBKYXNvbiBXYW5nIDxqYXNvd2FuZ0By ZWRoYXQuY29tPiB3cm90ZToKPgo+IOWcqCAyMDIyLzYvMjkgMTQ6NTYsIFh1YW4gWmh1byDlhpnp gZM6Cj4gPiBTZXBhcmF0ZSB0aGUgbG9naWMgb2Ygc3BsaXQgdG8gY3JlYXRlIHZyaW5nIHF1ZXVl Lgo+ID4KPiA+IFRoaXMgZmVhdHVyZSBpcyByZXF1aXJlZCBmb3Igc3Vic2VxdWVudCB2aXJ0dXF1 ZXVlIHJlc2V0IHZyaW5nLgo+ID4KPiA+IFNpZ25lZC1vZmYtYnk6IFh1YW4gWmh1byA8eHVhbnpo dW9AbGludXguYWxpYmFiYS5jb20+Cj4gPiAtLS0KPiA+ICAgZHJpdmVycy92aXJ0aW8vdmlydGlv X3JpbmcuYyB8IDY4ICsrKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLQo+ID4gICAx IGZpbGUgY2hhbmdlZCwgNDIgaW5zZXJ0aW9ucygrKSwgMjYgZGVsZXRpb25zKC0pCj4gPgo+ID4g ZGlmZiAtLWdpdCBhL2RyaXZlcnMvdmlydGlvL3ZpcnRpb19yaW5nLmMgYi9kcml2ZXJzL3ZpcnRp by92aXJ0aW9fcmluZy5jCj4gPiBpbmRleCA0OWQ2MWU0MTJkYzYuLmE5Y2ViOWMxNmM1NCAxMDA2 NDQKPiA+IC0tLSBhL2RyaXZlcnMvdmlydGlvL3ZpcnRpb19yaW5nLmMKPiA+ICsrKyBiL2RyaXZl cnMvdmlydGlvL3ZpcnRpb19yaW5nLmMKPiA+IEBAIC05NDksMjggKzk0OSwxOSBAQCBzdGF0aWMg dm9pZCB2cmluZ19mcmVlX3NwbGl0KHN0cnVjdCB2cmluZ192aXJ0cXVldWVfc3BsaXQgKnZyaW5n LAo+ID4gICAJa2ZyZWUodnJpbmctPmRlc2NfZXh0cmEpOwo+ID4gICB9Cj4gPgo+ID4gLXN0YXRp YyBzdHJ1Y3QgdmlydHF1ZXVlICp2cmluZ19jcmVhdGVfdmlydHF1ZXVlX3NwbGl0KAo+ID4gLQl1 bnNpZ25lZCBpbnQgaW5kZXgsCj4gPiAtCXVuc2lnbmVkIGludCBudW0sCj4gPiAtCXVuc2lnbmVk IGludCB2cmluZ19hbGlnbiwKPiA+IC0Jc3RydWN0IHZpcnRpb19kZXZpY2UgKnZkZXYsCj4gPiAt CWJvb2wgd2Vha19iYXJyaWVycywKPiA+IC0JYm9vbCBtYXlfcmVkdWNlX251bSwKPiA+IC0JYm9v bCBjb250ZXh0LAo+ID4gLQlib29sICgqbm90aWZ5KShzdHJ1Y3QgdmlydHF1ZXVlICopLAo+ID4g LQl2b2lkICgqY2FsbGJhY2spKHN0cnVjdCB2aXJ0cXVldWUgKiksCj4gPiAtCWNvbnN0IGNoYXIg Km5hbWUpCj4gPiArc3RhdGljIGludCB2cmluZ19hbGxvY19xdWV1ZV9zcGxpdChzdHJ1Y3QgdnJp bmdfdmlydHF1ZXVlX3NwbGl0ICp2cmluZywKPiA+ICsJCQkJICAgc3RydWN0IHZpcnRpb19kZXZp Y2UgKnZkZXYsCj4gPiArCQkJCSAgIHUzMiBudW0sCj4gPiArCQkJCSAgIHVuc2lnbmVkIGludCB2 cmluZ19hbGlnbiwKPiA+ICsJCQkJICAgYm9vbCBtYXlfcmVkdWNlX251bSkKPiA+ICAgewo+ID4g LQlzdHJ1Y3QgdmlydHF1ZXVlICp2cTsKPiA+ICAgCXZvaWQgKnF1ZXVlID0gTlVMTDsKPiA+ICAg CWRtYV9hZGRyX3QgZG1hX2FkZHI7Cj4gPiAtCXNpemVfdCBxdWV1ZV9zaXplX2luX2J5dGVzOwo+ ID4gLQlzdHJ1Y3QgdnJpbmcgdnJpbmc7Cj4gPgo+ID4gICAJLyogV2UgYXNzdW1lIG51bSBpcyBh IHBvd2VyIG9mIDIuICovCj4gPiAgIAlpZiAobnVtICYgKG51bSAtIDEpKSB7Cj4gPiAgIAkJZGV2 X3dhcm4oJnZkZXYtPmRldiwgIkJhZCB2aXJ0cXVldWUgbGVuZ3RoICV1XG4iLCBudW0pOwo+ID4g LQkJcmV0dXJuIE5VTEw7Cj4gPiArCQlyZXR1cm4gLUVJTlZBTDsKPiA+ICAgCX0KPiA+Cj4gPiAg IAkvKiBUT0RPOiBhbGxvY2F0ZSBlYWNoIHF1ZXVlIGNodW5rIGluZGl2aWR1YWxseSAqLwo+ID4g QEAgLTk4MSwxMSArOTcyLDExIEBAIHN0YXRpYyBzdHJ1Y3QgdmlydHF1ZXVlICp2cmluZ19jcmVh dGVfdmlydHF1ZXVlX3NwbGl0KAo+ID4gICAJCWlmIChxdWV1ZSkKPiA+ICAgCQkJYnJlYWs7Cj4g PiAgIAkJaWYgKCFtYXlfcmVkdWNlX251bSkKPiA+IC0JCQlyZXR1cm4gTlVMTDsKPiA+ICsJCQly ZXR1cm4gLUVOT01FTTsKPiA+ICAgCX0KPiA+Cj4gPiAgIAlpZiAoIW51bSkKPiA+IC0JCXJldHVy biBOVUxMOwo+ID4gKwkJcmV0dXJuIC1FTk9NRU07Cj4gPgo+ID4gICAJaWYgKCFxdWV1ZSkgewo+ ID4gICAJCS8qIFRyeSB0byBnZXQgYSBzaW5nbGUgcGFnZS4gWW91IGFyZSBteSBvbmx5IGhvcGUh ICovCj4gPiBAQCAtOTkzLDIxICs5ODQsNDYgQEAgc3RhdGljIHN0cnVjdCB2aXJ0cXVldWUgKnZy aW5nX2NyZWF0ZV92aXJ0cXVldWVfc3BsaXQoCj4gPiAgIAkJCQkJICAmZG1hX2FkZHIsIEdGUF9L RVJORUx8X19HRlBfWkVSTyk7Cj4gPiAgIAl9Cj4gPiAgIAlpZiAoIXF1ZXVlKQo+ID4gLQkJcmV0 dXJuIE5VTEw7Cj4gPiArCQlyZXR1cm4gLUVOT01FTTsKPiA+ICsKPiA+ICsJdnJpbmdfaW5pdCgm dnJpbmctPnZyaW5nLCBudW0sIHF1ZXVlLCB2cmluZ19hbGlnbik7Cj4gPgo+ID4gLQlxdWV1ZV9z aXplX2luX2J5dGVzID0gdnJpbmdfc2l6ZShudW0sIHZyaW5nX2FsaWduKTsKPiA+IC0JdnJpbmdf aW5pdCgmdnJpbmcsIG51bSwgcXVldWUsIHZyaW5nX2FsaWduKTsKPiA+ICsJdnJpbmctPnF1ZXVl X2RtYV9hZGRyID0gZG1hX2FkZHI7Cj4gPiArCXZyaW5nLT5xdWV1ZV9zaXplX2luX2J5dGVzID0g dnJpbmdfc2l6ZShudW0sIHZyaW5nX2FsaWduKTsKPiA+ICsKPiA+ICsJcmV0dXJuIDA7Cj4gPiAr fQo+ID4gKwo+ID4gK3N0YXRpYyBzdHJ1Y3QgdmlydHF1ZXVlICp2cmluZ19jcmVhdGVfdmlydHF1 ZXVlX3NwbGl0KAo+ID4gKwl1bnNpZ25lZCBpbnQgaW5kZXgsCj4gPiArCXVuc2lnbmVkIGludCBu dW0sCj4gPiArCXVuc2lnbmVkIGludCB2cmluZ19hbGlnbiwKPiA+ICsJc3RydWN0IHZpcnRpb19k ZXZpY2UgKnZkZXYsCj4gPiArCWJvb2wgd2Vha19iYXJyaWVycywKPiA+ICsJYm9vbCBtYXlfcmVk dWNlX251bSwKPiA+ICsJYm9vbCBjb250ZXh0LAo+ID4gKwlib29sICgqbm90aWZ5KShzdHJ1Y3Qg dmlydHF1ZXVlICopLAo+ID4gKwl2b2lkICgqY2FsbGJhY2spKHN0cnVjdCB2aXJ0cXVldWUgKiks Cj4gPiArCWNvbnN0IGNoYXIgKm5hbWUpCj4gPiArewo+ID4gKwlzdHJ1Y3QgdnJpbmdfdmlydHF1 ZXVlX3NwbGl0IHZyaW5nID0ge307Cj4gPiArCXN0cnVjdCB2aXJ0cXVldWUgKnZxOwo+ID4gKwlp bnQgZXJyOwo+ID4gKwo+ID4gKwllcnIgPSB2cmluZ19hbGxvY19xdWV1ZV9zcGxpdCgmdnJpbmcs IHZkZXYsIG51bSwgdnJpbmdfYWxpZ24sCj4gPiArCQkJCSAgICAgIG1heV9yZWR1Y2VfbnVtKTsK PiA+ICsJaWYgKGVycikKPiA+ICsJCXJldHVybiBOVUxMOwo+ID4KPiA+IC0JdnEgPSBfX3ZyaW5n X25ld192aXJ0cXVldWUoaW5kZXgsIHZyaW5nLCB2ZGV2LCB3ZWFrX2JhcnJpZXJzLCBjb250ZXh0 LAo+ID4gLQkJCQkgICBub3RpZnksIGNhbGxiYWNrLCBuYW1lKTsKPiA+ICsJdnEgPSBfX3ZyaW5n X25ld192aXJ0cXVldWUoaW5kZXgsIHZyaW5nLnZyaW5nLCB2ZGV2LCB3ZWFrX2JhcnJpZXJzLAo+ ID4gKwkJCQkgICBjb250ZXh0LCBub3RpZnksIGNhbGxiYWNrLCBuYW1lKTsKPiA+ICAgCWlmICgh dnEpIHsKPiA+IC0JCXZyaW5nX2ZyZWVfcXVldWUodmRldiwgcXVldWVfc2l6ZV9pbl9ieXRlcywg cXVldWUsCj4gPiAtCQkJCSBkbWFfYWRkcik7Cj4gPiArCQl2cmluZ19mcmVlX3NwbGl0KCZ2cmlu ZywgdmRldik7Cj4gPiAgIAkJcmV0dXJuIE5VTEw7Cj4gPiAgIAl9Cj4gPgo+ID4gLQl0b192dnEo dnEpLT5zcGxpdC5xdWV1ZV9kbWFfYWRkciA9IGRtYV9hZGRyOwo+ID4gLQl0b192dnEodnEpLT5z cGxpdC5xdWV1ZV9zaXplX2luX2J5dGVzID0gcXVldWVfc2l6ZV9pbl9ieXRlczsKPiA+ICsJdG9f dnZxKHZxKS0+c3BsaXQucXVldWVfZG1hX2FkZHIgPSB2cmluZy5xdWV1ZV9kbWFfYWRkcjsKPgo+ Cj4gTml0OiBoYXZpbmcgdHdvIHF1ZXVlX2RtYV9hZGRyIHNlZW1zIHJlZHVuZGFudCAoc28gZGlk IHF1ZXVlX3NpemVfaW5fYnl0ZXMpLgoKdHdvPwoKV2hlcmUgaXMgdGhlIHByb2JsZW0gSSBkb24n dCB1bmRlcnN0YW5kPwoKVGhhbmtzLgoKPgo+IFRoYW5rcwo+Cj4KPiA+ICsJdG9fdnZxKHZxKS0+ c3BsaXQucXVldWVfc2l6ZV9pbl9ieXRlcyA9IHZyaW5nLnF1ZXVlX3NpemVfaW5fYnl0ZXM7Cj4g PiAgIAl0b192dnEodnEpLT53ZV9vd25fcmluZyA9IHRydWU7Cj4gPgo+ID4gICAJcmV0dXJuIHZx Owo+CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51 eC11bSBtYWlsaW5nIGxpc3QKbGludXgtdW1AbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlz dHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXVtCg==