From: "NeilBrown" <neil@brown.name>
To: "Al Viro" <viro@zeniv.linux.org.uk>
Cc: "Christian Brauner" <brauner@kernel.org>,
"Jan Kara" <jack@suse.cz>, "David Howells" <dhowells@redhat.com>,
"Marc Dionne" <marc.dionne@auristor.com>,
"Xiubo Li" <xiubli@redhat.com>,
"Ilya Dryomov" <idryomov@gmail.com>,
"Tyler Hicks" <code@tyhicks.com>,
"Miklos Szeredi" <miklos@szeredi.hu>,
"Richard Weinberger" <richard@nod.at>,
"Anton Ivanov" <anton.ivanov@cambridgegreys.com>,
"Johannes Berg" <johannes@sipsolutions.net>,
"Trond Myklebust" <trondmy@kernel.org>,
"Anna Schumaker" <anna@kernel.org>,
"Chuck Lever" <chuck.lever@oracle.com>,
"Jeff Layton" <jlayton@kernel.org>,
"Amir Goldstein" <amir73il@gmail.com>,
"Steve French" <sfrench@samba.org>,
"Namjae Jeon" <linkinjeon@kernel.org>,
"Carlos Maiolino" <cem@kernel.org>,
linux-fsdevel@vger.kernel.org, linux-afs@lists.infradead.org,
netfs@lists.linux.dev, ceph-devel@vger.kernel.org,
ecryptfs@vger.kernel.org, linux-um@lists.infradead.org,
linux-nfs@vger.kernel.org, linux-unionfs@vger.kernel.org,
linux-cifs@vger.kernel.org, linux-xfs@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 03/11] VFS: add dentry_lookup_killable()
Date: Wed, 13 Aug 2025 17:50:16 +1000 [thread overview]
Message-ID: <175507141618.2234665.4849620982329749562@noble.neil.brown.name> (raw)
In-Reply-To: <20250813041506.GZ222315@ZenIV>
On Wed, 13 Aug 2025, Al Viro wrote:
> On Tue, Aug 12, 2025 at 12:25:06PM +1000, NeilBrown wrote:
> > btrfs/ioctl.c uses a "killable" lock on the directory when creating an
> > destroying subvols. overlayfs also does this.
> >
> > This patch adds dentry_lookup_killable() for these users.
> >
> > Possibly all dentry_lookup should be killable as there is no down-side,
> > but that can come in a later patch.
>
> Same objections re lookup_flags and it would be better to do that
> at the same point where you convert the (btrfs and overlayfs?) callers.
>
I had trouble deciding whether it would be better to merge the patches
for easy review, or keep them separate in case they needed to go through
different trees.. I guess I decided wrongly.
NeiBrown
next prev parent reply other threads:[~2025-08-13 10:16 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-12 2:25 [PATCH 00/11] VFS: prepare for changes to directory locking NeilBrown
2025-08-12 2:25 ` [PATCH 01/11] VFS: discard err2 in filename_create() NeilBrown
2025-08-13 3:22 ` Al Viro
2025-08-12 2:25 ` [PATCH 02/11] VFS: introduce dentry_lookup() and friends NeilBrown
2025-08-13 4:12 ` Al Viro
2025-08-13 7:48 ` NeilBrown
2025-08-12 2:25 ` [PATCH 03/11] VFS: add dentry_lookup_killable() NeilBrown
2025-08-13 4:15 ` Al Viro
2025-08-13 7:50 ` NeilBrown [this message]
2025-08-12 2:25 ` [PATCH 04/11] VFS: introduce dentry_lookup_continue() NeilBrown
2025-08-13 4:22 ` Al Viro
2025-08-13 7:53 ` NeilBrown
2025-08-18 12:39 ` Amir Goldstein
2025-08-18 21:52 ` NeilBrown
2025-08-19 8:37 ` Amir Goldstein
2025-08-12 2:25 ` [PATCH 05/11] VFS: add rename_lookup() NeilBrown
2025-08-13 4:35 ` Al Viro
2025-08-13 8:04 ` NeilBrown
2025-08-14 1:40 ` Al Viro
2025-08-12 2:25 ` [PATCH 06/11] VFS: unify old_mnt_idmap and new_mnt_idmap in renamedata NeilBrown
2025-08-13 4:36 ` Al Viro
2025-08-12 2:25 ` [PATCH 07/11] VFS: Change vfs_mkdir() to unlock on failure NeilBrown
2025-08-13 7:22 ` Amir Goldstein
2025-08-14 1:13 ` NeilBrown
2025-08-14 13:29 ` Amir Goldstein
2025-08-12 2:25 ` [PATCH 08/11] VFS: allow d_splice_alias() and d_add() to work on hashed dentries NeilBrown
2025-08-13 5:07 ` Al Viro
2025-08-12 2:25 ` [PATCH 09/11] VFS: use global wait-queue table for d_alloc_parallel() NeilBrown
2025-08-13 6:44 ` Al Viro
2025-08-14 1:31 ` NeilBrown
2025-08-12 2:25 ` [PATCH 10/11] VFS: use d_alloc_parallel() in lookup_one_qstr_excl() NeilBrown
2025-08-13 5:19 ` Al Viro
2025-08-14 0:56 ` NeilBrown
2025-08-12 2:25 ` [PATCH 11/11] VFS: introduce d_alloc_noblock() and d_alloc_locked() NeilBrown
2025-08-13 6:53 ` Al Viro
2025-08-14 2:07 ` NeilBrown
2025-08-14 13:47 ` Amir Goldstein
2025-08-13 0:01 ` [PATCH 00/11] VFS: prepare for changes to directory locking Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175507141618.2234665.4849620982329749562@noble.neil.brown.name \
--to=neil@brown.name \
--cc=amir73il@gmail.com \
--cc=anna@kernel.org \
--cc=anton.ivanov@cambridgegreys.com \
--cc=brauner@kernel.org \
--cc=cem@kernel.org \
--cc=ceph-devel@vger.kernel.org \
--cc=chuck.lever@oracle.com \
--cc=code@tyhicks.com \
--cc=dhowells@redhat.com \
--cc=ecryptfs@vger.kernel.org \
--cc=idryomov@gmail.com \
--cc=jack@suse.cz \
--cc=jlayton@kernel.org \
--cc=johannes@sipsolutions.net \
--cc=linkinjeon@kernel.org \
--cc=linux-afs@lists.infradead.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=marc.dionne@auristor.com \
--cc=miklos@szeredi.hu \
--cc=netfs@lists.linux.dev \
--cc=richard@nod.at \
--cc=sfrench@samba.org \
--cc=trondmy@kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=xiubli@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).