From: Richard Weinberger <richard@nod.at>
To: Christopher Obbard <chris.obbard@collabora.com>
Cc: linux-um <linux-um@lists.infradead.org>,
Hajime Tazaki <thehajime@gmail.com>
Subject: Re: [PATCH] um: ubd: fix command line handling of ubd
Date: Mon, 4 Jan 2021 12:18:31 +0100 (CET) [thread overview]
Message-ID: <1915321888.202504.1609759111591.JavaMail.zimbra@nod.at> (raw)
In-Reply-To: <8ea288a9-d482-3295-266b-d00cc315d2c5@collabora.com>
----- Ursprüngliche Mail -----
> Von: "Christopher Obbard" <chris.obbard@collabora.com>
> An: "Richard Weinberger" <richard.weinberger@gmail.com>, "richard" <richard@nod.at>
> CC: "Hajime Tazaki" <thehajime@gmail.com>, "linux-um" <linux-um@lists.infradead.org>
> Gesendet: Montag, 4. Januar 2021 11:56:53
> Betreff: Re: [PATCH] um: ubd: fix command line handling of ubd
> Hi Richard,
>
> On 23/12/2020 10:19, Richard Weinberger wrote:
>> On Tue, Dec 22, 2020 at 12:49 PM Christopher Obbard
>> <chris.obbard@collabora.com> wrote:
>>>
>>> Hi Hajime,
>>>
>>> Doh! Thanks for sorting out this regression!
>>>
>>> On Monday, 21 December, 2020 02:24 GMT, Hajime Tazaki <thehajime@gmail.com>
>>> wrote:
>>>> This commit fixes a regression to handle command line parameters of ubd.
>>>> With a simple line "./linux ubd0="./disk-ext4.img", it fails at
>>>> ubd_setup_common(). The commit adds additional checks to the variables
>>>> in order to properly parse the paremeters which previously worked.
>>>>
>>>> Fixes: ef3ba87cb7c9 ("um: ubd: Set device serial attribute from
>>>> cmdline")
>>>> Cc: Christopher Obbard <chris.obbard@collabora.com>
>>>> Signed-off-by: Hajime Tazaki <thehajime@gmail.com>
>>>
>>> Acked-by: Christopher Obbard <chris.obbard@collabora.com>
>>
>> Applied, thx!
>>
>
> Hope you don't mind the extra poke message from me, but it didn't seem
> like this patch was applied to 5.11-rc2 & I cannot see the patch under
> your tree https://git.kernel.org/pub/scm/linux/kernel/git/rw/uml.git/
It is in my patchwork bundle and marked as accepted:
https://patchwork.ozlabs.org/bundle/rw/uml-5.11-rc1-fixes/?series=&submitter=&state=*&q=&archive=
Xmas happened before I could push it out and do a PR.
Thanks,
//richard
_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um
prev parent reply other threads:[~2021-01-04 11:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-21 2:24 [PATCH] um: ubd: fix command line handling of ubd Hajime Tazaki
2020-12-22 11:49 ` Christopher Obbard
2020-12-23 10:19 ` Richard Weinberger
2021-01-04 10:56 ` Christopher Obbard
2021-01-04 11:18 ` Richard Weinberger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1915321888.202504.1609759111591.JavaMail.zimbra@nod.at \
--to=richard@nod.at \
--cc=chris.obbard@collabora.com \
--cc=linux-um@lists.infradead.org \
--cc=thehajime@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox