From: Jens Axboe <axboe@kernel.dk>
To: Anton Ivanov <anton.ivanov@cambridgegreys.com>,
linux-um@lists.infradead.org
Cc: richard@nod.at, hch@lst.de
Subject: Re: New Patch series for the UBD Driver
Date: Mon, 12 Nov 2018 12:11:08 -0700 [thread overview]
Message-ID: <1e27868d-974b-9554-1010-a7e28a238479@kernel.dk> (raw)
In-Reply-To: <1d334c50-0f89-70e7-b6c7-fe0d719ed5df@cambridgegreys.com>
On 11/12/18 11:41 AM, Anton Ivanov wrote:
>>> And hang. Let me try a few more times to see if I can get the spinlock
>>> recursion and/or abort instead of hang case (they are more difficult to
>>> reproduce).
>> This shows exactly what I was talking about, you are trying to
>> issue IO from irq/non-blocking context. If you look up the warning,
>> that's exactly what it is telling you.
>
>
> So why does this happen only in the case of an error? Why nothing is
> triggered in the OK path?
>
> After adding this flag I no longer get the block/blk.h:439 The spinlock
> recursion and the other barfs are alive and well.
>
> Back to "what is that" - can I execute blk_update_request,
> __blk_mq_end_request, blk_mq_end_request out of an interrupt context?
>
> It seems that I can when error is BLK_STS_OK, but not when it is not.
Post a new stack trace with BLOCKING set. Of course you can call the end
request functions from irq context, most drivers end up doing that. For
OK and error.
There's something fundamentally wrong with your case, it might be reuse
or something like that.
--
Jens Axboe
_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um
next prev parent reply other threads:[~2018-11-12 19:11 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-12 17:41 New Patch series for the UBD Driver anton.ivanov
2018-11-12 17:41 ` [PATCH 1/3] um: Switch to block-mq constants in the UML UBD driver anton.ivanov
2018-11-12 17:48 ` Jens Axboe
2018-11-12 17:52 ` Anton Ivanov
2018-11-12 17:42 ` [PATCH 2/3] um: Clean-up command processing in " anton.ivanov
2018-11-12 17:42 ` [PATCH 3/3] um: Add support for DISCARD in the UBD Driver anton.ivanov
2018-11-12 17:50 ` New Patch series for " Jens Axboe
2018-11-12 18:00 ` Anton Ivanov
2018-11-12 18:04 ` Jens Axboe
2018-11-12 18:12 ` Anton Ivanov
2018-11-12 18:14 ` Jens Axboe
2018-11-12 18:23 ` Anton Ivanov
2018-11-12 18:24 ` Anton Ivanov
2018-11-12 18:28 ` Jens Axboe
2018-11-12 18:41 ` Anton Ivanov
2018-11-12 19:11 ` Jens Axboe [this message]
2018-11-12 19:26 ` Jens Axboe
2018-11-13 8:42 ` Anton Ivanov
2018-11-13 10:15 ` Anton Ivanov
2018-11-13 10:20 ` Anton Ivanov
2018-11-13 13:30 ` Jens Axboe
2018-11-13 13:56 ` Anton Ivanov
2018-11-13 15:14 ` Jens Axboe
2018-11-13 15:24 ` Anton Ivanov
2018-11-13 15:29 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e27868d-974b-9554-1010-a7e28a238479@kernel.dk \
--to=axboe@kernel.dk \
--cc=anton.ivanov@cambridgegreys.com \
--cc=hch@lst.de \
--cc=linux-um@lists.infradead.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox