[PATCH] um: Include linux/types.h in asm/fpu/api.h

[PATCH] um: Include linux/types.h in asm/fpu/api.h

[Herbert Xu]

On Wed, May 07, 2025 at 12:25:45AM +0800, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
> head:   9b9d4ef0cf750c514735bfd77745387b95cbddda
> commit: 5b90a779bc547939421bfeb333e470658ba94fb6 [50/70] crypto: lib/sha256 - Add helpers for block-based shash
> config: um-randconfig-001-20250506 (https://download.01.org/0day-ci/archive/20250507/202505070045.vWc04ygs-lkp@intel.com/config)
> compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18)
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250507/202505070045.vWc04ygs-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202505070045.vWc04ygs-lkp@intel.com/
> 
> All errors (new ones prefixed by >>):
> 
>    In file included from lib/crypto/sha256.c:14:
>    In file included from include/crypto/internal/sha2.h:6:
>    In file included from include/crypto/internal/simd.h:9:
>    In file included from arch/x86/include/asm/simd.h:5:
> >> arch/um/include/asm/fpu/api.h:14:15: error: unknown type name 'bool'
>       14 | static inline bool irq_fpu_usable(void)
>          |               ^
> >> arch/um/include/asm/fpu/api.h:16:9: error: use of undeclared identifier 'true'
>       16 |         return true;
>          |                ^
>    2 errors generated.

I'll add this to the crypto tree if it's OK with the UML maintainers.

Thanks,

---8<---
Include linux/types.h before using bool.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202505070045.vWc04ygs-lkp@intel.com/
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

diff --git a/arch/um/include/asm/fpu/api.h b/arch/um/include/asm/fpu/api.h
index 71bfd9ef3938..3abf67c83c40 100644
--- a/arch/um/include/asm/fpu/api.h
+++ b/arch/um/include/asm/fpu/api.h
@@ -2,6 +2,8 @@
 #ifndef _ASM_UM_FPU_API_H
 #define _ASM_UM_FPU_API_H
 
+#include <linux/types.h>
+
 /* Copyright (c) 2020 Cambridge Greys Ltd
  * Copyright (c) 2020 Red Hat Inc.
  * A set of "dummy" defines to allow the direct inclusion
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] um: Include linux/types.h in asm/fpu/api.h

[Johannes Berg]

On Wed, 2025-05-07 at 09:41 +0800, Herbert Xu wrote:
> 
> I'll add this to the crypto tree if it's OK with the UML maintainers.

Sure, seems trivial enough and nobody is likely to touch that file.

Thanks.

> ---8<---
> Include linux/types.h before using bool.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202505070045.vWc04ygs-lkp@intel.com/
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

Acked-by: Johannes Berg <johannes@sipsolutions.net>

johannes