Re: [uml-devel] Re: First shrinkage of *_user.c files

[BlaisorBlade <blaisorblade_spam@yahoo.it>]

Alle 21:34, martedì 20 gennaio 2004, Jeff Dike ha scritto:
> blaisorblade_spam@yahoo.it said:
> > I've started removing some functions from the user_objs, and here
> > there are  the two first patches. Any comment on the style of these
> > changes is highly  appreciated. The next thing I'm going to do is to
> > remove entirely  hostaudio_user.c (I've already started this, but I've
> > not got a successful  test yet, since I also did a little fix in
> > this).
>
> Yeah, that's the style I'm looking for.  The goal should be to eliminate
> anything outside of arch/um/os needing any libc headers.
>
> Try to extract the essence of the libc dependency into arch/um/os rather
> than just moving large chunks of code there, which looks like what you're
> doing.
I added a function to os- and moved some other ones away from _user files.

The first is not too tiny because some other system could not have the 
termios.h abstraction, so it must be more abstract (for Windows it will 
probably be a no-op, since there is no support in the OS IMHO).

The moved functions didn't depend on userspace so I just moved them (they are 
tiny wrappers but are needed for some structures).

However, see the next patches I posted for more changes.

Bye
-- 
cat <<EOSIGN
Paolo Giarrusso, aka Blaisorblade
Linux Kernel 2.4.23/2.6.0 on an i686; Linux registered user n. 292729
EOSIGN



-------------------------------------------------------
The SF.Net email is sponsored by EclipseCon 2004
Premiere Conference on Open Tools Development and Integration
See the breadth of Eclipse activity. February 3-5 in Anaheim, CA.
http://www.eclipsecon.org/osdn
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel