From: Jeff Dike <jdike@addtoit.com>
To: Dan Shearer <dan@shearer.org>
Cc: user-mode-linux-devel@lists.sourceforge.net
Subject: [uml-devel] Re: PATCH kernel/umid.c
Date: Tue, 27 Jan 2004 20:46:36 -0500 [thread overview]
Message-ID: <200401280146.i0S1kaZw004952@ccure.user-mode-linux.org> (raw)
In-Reply-To: Your message of "Mon, 26 Jan 2004 23:17:08 +1030." <20040126124708.GH4203@erizo.shearer.org>
dan@shearer.org said:
> - return(0);
> + return(1);
I did the return(0) on purpose because, even though initcall procedures are
declared as returning an int, do_initcalls ignores it.
So, I added a comment there instead of changing the return value.
> In addition, umid.c seems to be a bit inconsistent as to what rates an
> exit(1) and what just does return(1).
Stuff that's done early, before the kernel is actually running, rates an
exit(1). Everything else gets a return(1). I don't always follow this rule,
but I did a quick check of umid.c and it looks OK.
Jeff
Jeff
-------------------------------------------------------
The SF.Net email is sponsored by EclipseCon 2004
Premiere Conference on Open Tools Development and Integration
See the breadth of Eclipse activity. February 3-5 in Anaheim, CA.
http://www.eclipsecon.org/osdn
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
prev parent reply other threads:[~2004-01-28 1:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-26 12:47 [uml-devel] PATCH kernel/umid.c Dan Shearer
2004-01-26 13:03 ` [uml-devel] " Dan Shearer
2004-01-28 1:46 ` Jeff Dike [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200401280146.i0S1kaZw004952@ccure.user-mode-linux.org \
--to=jdike@addtoit.com \
--cc=dan@shearer.org \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox