From: BlaisorBlade <blaisorblade_spam@yahoo.it>
To: user-mode-linux-devel@lists.sourceforge.net
Cc: Matt Ayres <matta@tektonic.net>
Subject: Re: [uml-devel] [PATCH] skas3 for x86_64 arch
Date: Fri, 20 Feb 2004 21:55:44 +0100 [thread overview]
Message-ID: <200402202155.44773.blaisorblade_spam@yahoo.it> (raw)
In-Reply-To: <1077305069.8412.62.camel@wopr.tektonic.net>
Alle 20:24, venerdì 20 febbraio 2004, Matt Ayres ha scritto:
> Hi,
>
> I just did a quick port of the skas3 patch to the x86_64 architecture.
> Everything seems very straightforward except for the do_mmap2 function.
Sorry, but you've changed the prototype of sys32_mmap2 by adding the mm
parameter (which goes only on do_mmap2). So it cannot possibly compile.
-asmlinkage long sys32_mmap2(unsigned long addr, unsigned long len,
+/* common code for old and new mmaps */
+static inline long do_mmap2(struct mm_struct *mm,
+unsigned long addr, unsigned long len,
unsigned long prot, unsigned long flags,
unsigned long fd, unsigned long pgoff)
+
+asmlinkage long sys32_mmap2(struct mm_struct *mm,
+unsigned long addr, unsigned long len,
+unsigned long prot, unsigned long flags,
+unsigned long fd, unsigned long pgoff)
+{
+return do_mmap2(addr, len, prot, flags, fd, pgoff);
+}
+
Apart for this, I did not see anything strange (but I give a *very* quick
look, i.e. 1 minute, so I'm not sure).
> I don't have a x86_64 machine or an emulator so I can't even verify this
> even compiles.
Have you tried a cross build with make ARCH=x86_64 ? I'm not sure if that can
work or requires cross-compilators, but maybe not.
--
Paolo Giarrusso, aka Blaisorblade
Linux registered user n. 292729
-------------------------------------------------------
SF.Net is sponsored by: Speed Start Your Linux Apps Now.
Build and deploy apps & Web services for Linux with
a free DVD software kit from IBM. Click Now!
http://ads.osdn.com/?ad_id\x1356&alloc_id438&opÌk
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
next prev parent reply other threads:[~2004-02-20 20:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-20 19:24 [uml-devel] [PATCH] skas3 for x86_64 arch Matt Ayres
2004-02-20 20:55 ` BlaisorBlade [this message]
2004-02-20 21:05 ` Matt Ayres
2004-02-21 9:45 ` Cameron Patrick
2004-02-22 2:51 ` matta
2004-02-22 3:06 ` Cameron Patrick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200402202155.44773.blaisorblade_spam@yahoo.it \
--to=blaisorblade_spam@yahoo.it \
--cc=matta@tektonic.net \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox