Re: skas and vserver on 2.4.25 (Re: [uml-devel] new skas3 patch ready for 2.4.25)

[BlaisorBlade <blaisorblade_spam@yahoo.it>]

Alle 07:30, lunedì 23 febbraio 2004, Nicholas Lee ha scritto:
> On Fri, Feb 20, 2004 at 09:25:57PM +0100, BlaisorBlade wrote:
> > Yes, it went away, so a new skas patch must be built. I have one (tested)
> > at http://www.user-mode-linux.org/~blaisorblade/
>
> Using this patch against against 2.4.25 with evmns, libata and the
> vserver patch, I get the following compilation error:-

You mean libata for Serial ATA support, EVMS from IBM as a LVM+RAID, right? 
But what is vserver?

>
> nic@stateless:/usr/src/linux-2.4.25-vs1.3.7/mm$ gcc -D__KERNEL__
> -I/usr/src/linux-2.4.25-vs1.3.7/include -Wall -Wstrict-prototypes
> -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common -fomit-frame-pointer
> -pipe -mpreferred-stack-boundary=2 -march=i686   -nostdinc -iwithprefix
> include -DKBUILD_BASENAME=proc_mm  -c -o proc_mm.o proc_mm.c proc_mm.c: In
> function `open_proc_mm':
> proc_mm.c:109: error: too few arguments to function `mm_alloc'
>
>
> mm_alloc seems to come from:
>
> <linux/sched.h>
> ...
> extern struct mm_struct * mm_alloc(struct vx_info *);
>
>
> vx_info is defined in <linux/vserver/context.h>
>
>
> Looks like vserver has redefined:-
>
> -extern struct mm_struct * mm_alloc(void);
> +extern struct mm_struct * mm_alloc(struct vx_info *);
>
>
> I don't know the kernel well enough to add the appropiate call to:
>
> static int open_proc_mm(struct inode *inode, struct file *file)
> {
>         struct mm_struct *mm = mm_alloc();
>
> I'm guessing it might be something like
>
>                mm_alloc(current->vx_info);

If you want to try yourself: "current" type is struct task_struct *, which is 
defined in linux/sched.h; check if a such member is defined in that struct, 
and if it is so you can try doing what you suggest and running the resulting 
kernel. But you could also "learn by samples": look in the "vserver" patch 
how the new mm_alloc is used, and what vx_info stands for (i.e. - what fields 
it contains and when mm_alloc is passed something different than 
current->vx_info).

However, if you want something reliable enough, post a pointer to the exact 
patch file that you applied for "vserver", and a description of what it does 
(an URL describing it or the "vserver" project homepage could suffice for the 
description). If I have time I could answer you saying what you do, i.e. if a 
such change can suffice or if the two patches interfere too much.

-- 
Paolo Giarrusso, aka Blaisorblade
Linux registered user n. 292729



-------------------------------------------------------
SF.Net is sponsored by: Speed Start Your Linux Apps Now.
Build and deploy apps & Web services for Linux with
a free DVD software kit from IBM. Click Now!
http://ads.osdn.com/?ad_id\x1356&alloc_id438&opÌk
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel