From: Pete Zaitcev <zaitcev@redhat.com>
To: user-mode-linux-devel@lists.sourceforge.net
Cc: zaitcev@redhat.com
Subject: [uml-devel] missed_ticks (2.6)
Date: Sun, 29 Feb 2004 19:19:32 -0800 [thread overview]
Message-ID: <20040229191932.10b3592e.zaitcev@redhat.com> (raw)
Hi,
I was looking at the way timer works on UML and noticed that missed_ticks
is not actually used for anything. Is there a plan for it? If not, maybe
we should drop it.
Cheers,
-- Pete
diff -ur -X dontdiff linux-2.6.3-rc2-uml-1/arch/um/kernel/skas/trap_user.c linux-2.6.3-rc2-uml-1-t1/arch/um/kernel/skas/trap_user.c
--- linux-2.6.3-rc2-uml-1/arch/um/kernel/skas/trap_user.c 2004-02-15 21:26:30.000000000 -0800
+++ linux-2.6.3-rc2-uml-1-t1/arch/um/kernel/skas/trap_user.c 2004-02-29 18:48:11.000000000 -0800
@@ -35,8 +35,6 @@
errno = save_errno;
}
-extern int missed_ticks[];
-
void user_signal(int sig, union uml_pt_regs *regs)
{
struct signal_info *info;
diff -ur -X dontdiff linux-2.6.3-rc2-uml-1/arch/um/kernel/time_kern.c linux-2.6.3-rc2-uml-1-t1/arch/um/kernel/time_kern.c
--- linux-2.6.3-rc2-uml-1/arch/um/kernel/time_kern.c 2004-02-15 21:26:31.000000000 -0800
+++ linux-2.6.3-rc2-uml-1-t1/arch/um/kernel/time_kern.c 2004-02-29 19:02:44.000000000 -0800
@@ -41,12 +41,6 @@
/* Changed at early boot */
int timer_irq_inited = 0;
-/* missed_ticks will be modified after kernel memory has been
- * write-protected, so this puts it in a section which will be left
- * write-enabled.
- */
-int __attribute__ ((__section__ (".unprotected"))) missed_ticks[NR_CPUS];
-
static int first_tick;
static unsigned long long prev_tsc;
static long long delta; /* Deviation per interval */
diff -ur -X dontdiff linux-2.6.3-rc2-uml-1/arch/um/kernel/trap_user.c linux-2.6.3-rc2-uml-1-t1/arch/um/kernel/trap_user.c
--- linux-2.6.3-rc2-uml-1/arch/um/kernel/trap_user.c 2004-02-15 21:26:31.000000000 -0800
+++ linux-2.6.3-rc2-uml-1-t1/arch/um/kernel/trap_user.c 2004-02-29 19:02:28.000000000 -0800
@@ -102,12 +102,11 @@
sig, &sc);
}
-extern int timer_irq_inited, missed_ticks[];
+extern int timer_irq_inited;
void alarm_handler(int sig, struct sigcontext sc)
{
if(!timer_irq_inited) return;
- missed_ticks[cpu()]++;
if(sig == SIGALRM)
switch_timers(0);
-------------------------------------------------------
SF.Net is sponsored by: Speed Start Your Linux Apps Now.
Build and deploy apps & Web services for Linux with
a free DVD software kit from IBM. Click Now!
http://ads.osdn.com/?ad_id=1356&alloc_id=3438&op=click
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
next reply other threads:[~2004-03-01 3:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-01 3:19 Pete Zaitcev [this message]
2004-03-01 4:33 ` [uml-devel] missed_ticks (2.6) Jeff Dike
2004-03-11 21:53 ` Jeff Dike
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040229191932.10b3592e.zaitcev@redhat.com \
--to=zaitcev@redhat.com \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox