Re: [uml-devel] RFC: lossless printk

[Werner Almesberger <werner@almesberger.net>]

Adam Heath wrote:
> Don't define functions inline like that, place it in a header.

Of course. I just didn't want to touch yet another file for
now. After all, that's just a first try to get feedback.

> The code shouldn't retry forever.  If the output is blocked for a long time,
> the kernel will become stalled.

Hmm, that's a tricky one. What's a good policy in this case ?
Wait up to a fixed amount of time before continuing, and perhaps
do the same thing on the next printk ? Stop retrying after one
timeout ? Make all this configurable ?

> You also don't handle EINTR.

Good point. I actually never saw one happen, even though I have
workloads that almost only printk.

> Are you converting errno to a list of hashes?

Yeah :-) I'll fix this. You hit it usually for EPIPE or the
like.

> And couldn't writing to stderr
> have the same non-blocking problems?

Potentially yes. Not sure if it makes sense to try very hard
to get that last message out, though.

- Werner

-- 
  _________________________________________________________________________
 / Werner Almesberger, Buenos Aires, Argentina     werner@almesberger.net /
/_http://www.almesberger.net/____________________________________________/


-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel