From: Marcin Pawlik <wapkil@op.pl>
To: Henrik Nordstrom <uml@henrik.marasystems.com>
Cc: user-mode-linux-devel@lists.sourceforge.net
Subject: Re: [uml-devel] [patch] Re: Reboot failing with file locked, CLONE_FILES and host kernel BUG()
Date: Wed, 14 Apr 2004 15:46:04 +0200 [thread overview]
Message-ID: <20040414134604.GA24262@mpmain> (raw)
In-Reply-To: <20040414133215.GA7464@mpmain>
On Wed, Apr 14 at 15:32, Marcin Pawlik wrote:
> Do you know where and which thread closes the files? I tried to add
> file closing to kill_io_thread() (patch attached) and it helps
[...]
> diff -urN kernel-source-2.4.24/arch/um/drivers/ubd_kern.c
> kernel-source-2.4.24.mp/arch/um/drivers/ubd_kern.c ---
> kernel-source-2.4.24/arch/um/drivers/ubd_kern.c 2004-04-14
> 14:38:21.000000000 +0200
> +++ kernel-source-2.4.24.mp/arch/um/drivers/ubd_kern.c 2004-04-14
> 14:42:55.000000000 +0200 @@ -495,6 +495,16 @@
>
> void kill_io_thread(void)
> {
> + int i;
> + struct ubd * ubd_devp = ubd_dev;
> +
> + for(i = 0; i < MAX_DEV; i++, ubd_devp++) {
> + if(ubd_devp) {
> + os_close_file(ubd_devp->fd);
> + close(ubd_devp->cow.fd);
To be consistent I should of course change the line above to
"os_close_file(ubd_devp->cow.fd);", sorry.
Regards,
--
Marcin Pawlik
-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
next prev parent reply other threads:[~2004-04-14 14:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-13 21:23 [uml-devel] Reboot failing with file locked, CLONE_FILES and host kernel BUG() Marcin Pawlik
2004-04-14 1:13 ` [uml-devel] [patch] " Henrik Nordstrom
2004-04-14 13:32 ` Marcin Pawlik
2004-04-14 13:46 ` Marcin Pawlik [this message]
2004-04-14 14:44 ` Henrik Nordstrom
2004-04-14 17:09 ` Marcin Pawlik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040414134604.GA24262@mpmain \
--to=wapkil@op.pl \
--cc=uml@henrik.marasystems.com \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox