From: Piotr Neuman <sikkh@wp.pl>
To: user-mode-linux-devel@lists.sourceforge.net
Subject: [uml-devel] Humfs directory creation bug.
Date: Mon, 7 Jun 2004 18:44:27 +0200 [thread overview]
Message-ID: <200406071844.27297.sikkh@wp.pl> (raw)
[-- Attachment #1: Type: text/plain, Size: 774 bytes --]
Humfs code misreported device when getting stat info on directories. This code
hopefully fixes that (mv will work with hardlinks as expected now).
Apply to 2.4.26-1 UML release (in arch/um/fs/hostfs/). Patch:
Index: externfs.c
===================================================================
--- externfs.c (revision 708)
+++ externfs.c (working copy)
@@ -844,7 +844,6 @@
return(-ENOMEM);
err = (*ops->make_dir)(file, mode, current->fsuid, current->fsgid,
mount);
- kfree(file);
inode = get_inode(ino->i_sb, dentry, ops, 1);
if(IS_ERR(inode)){
@@ -852,6 +851,11 @@
goto out;
}
+ err = read_name(inode, file);
+ kfree(file);
+ if(err)
+ goto out;
+
d_instantiate(dentry, inode);
inode->i_nlink = 2;
inode->i_mode = S_IFDIR | mode;
[-- Attachment #2: humfs_mkdir.patch --]
[-- Type: text/x-diff, Size: 561 bytes --]
Index: externfs.c
===================================================================
--- externfs.c (revision 708)
+++ externfs.c (working copy)
@@ -844,7 +844,6 @@
return(-ENOMEM);
err = (*ops->make_dir)(file, mode, current->fsuid, current->fsgid,
mount);
- kfree(file);
inode = get_inode(ino->i_sb, dentry, ops, 1);
if(IS_ERR(inode)){
@@ -852,6 +851,11 @@
goto out;
}
+ err = read_name(inode, file);
+ kfree(file);
+ if(err)
+ goto out;
+
d_instantiate(dentry, inode);
inode->i_nlink = 2;
inode->i_mode = S_IFDIR | mode;
next reply other threads:[~2004-06-07 16:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-07 16:44 Piotr Neuman [this message]
2004-07-01 1:00 ` [uml-devel] Humfs directory creation bug Jeff Dike
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200406071844.27297.sikkh@wp.pl \
--to=sikkh@wp.pl \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox