[uml-devel] Re: [patch 1/1] Fix malloc-use-vmalloc

[Jeff Dike <jdike@addtoit.com>]

blaisorblade_spam@yahoo.it said:
> * Avoid allocating more than one page at once: that can require moving
> pages around to have two contiguos pages, so we're better with
> vmalloc. 

Yup, makes sense.

> * Make sure we free() someway, inside __wrap_free. 

This isn't exactly right.  In the case that a buffer was allocated by kmalloc 
(through malloc), but freed when the system is coming down, and kmalloc is no 
longer operating, then you just want to do nothing. It would be very bad to
try to free it using libc free.

So, what I did is this:

	if((addr >= uml_physmem) && (addr <= high_physmem)){
		if(CAN_KMALLOC())
			kfree(ptr);
	}
	else if((addr >= start_vm) && (addr <= end_vm)){
		if(CAN_KMALLOC())
			vfree(ptr);
	}
	else __real_free(ptr);


				Jeff



-------------------------------------------------------
This SF.Net email sponsored by Black Hat Briefings & Training.
Attend Black Hat Briefings & Training, Las Vegas July 24-29 - 
digital self defense, top technical experts, no vendor pitches, 
unmatched networking opportunities. Visit www.blackhat.com
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel