Re: [uml-devel] [patch] host-skas3 for 2.6.9-rc2

[BlaisorBlade <blaisorblade_spam@yahoo.it>]

On Thursday 16 September 2004 15:39, Gerd Knorr wrote:
> On Thu, Sep 16, 2004 at 01:03:23PM +0200, Gerd Knorr wrote:
> > Some change between -rc1 and -rc1-bk1 broke the skas patch, still
> > looking ...
>
> Found it: init_new_empty_context needs a arch_pick_mmap_layout call,
> otherwise we'll get a NULL ptr dereferences for the function pointers
> added recently to mm_struct.
Well, please cleanup it, because you are affecting the behaviour on fork() 
(the change should be harmless, however, just repeating 
arch_pick_mmap_layout()).

Without the SKAS patch, init_new_context does not call 
arch_pick_mmap_layout(), so it should not after ( and init_new_context calls, 
actually, init_new_empty_context()). I think that the proper place to add the 
call is open_proc_mm(). Do you agree on this?

Bye
-- 
Paolo Giarrusso, aka Blaisorblade
Linux registered user n. 292729


-------------------------------------------------------
This SF.Net email is sponsored by: YOU BE THE JUDGE. Be one of 170
Project Admins to receive an Apple iPod Mini FREE for your judgement on
who ports your project to Linux PPC the best. Sponsored by IBM.
Deadline: Sept. 24. Go here: http://sf.net/ppc_contest.php
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel