Re: [uml-devel] Updated token-limiter patch, was 2.6.9-bb3 creates zombie threads in SKAS

[Blaisorblade <blaisorblade_spam@yahoo.it>]

On Tuesday 23 November 2004 08:28, Christopher S. Aker wrote:
> > > > Btw, question: what about your I/O token limiter? Actively using it?
> > > > Could start being worked on for merge (there is at least one
> > > > bug-report on it by "roland" on a strange but valid test-case).

> > see http://sourceforge.net/mailarchive/message.php?msg_id=8560363

> > that`s probably just a minor one.

> > roland

> From that post:
> > ps:
> > the token limiter seems to have a little bug:
> > set token_refill=1
> > do a "dd if=/dev/zero of=test.dat bs=1024k count=whatever"
> > then "sync".

> I see.  nanosleep doesn't accept an tv_nsec value over 999  999  999, so
> there's a simple fix in this patch:

> http://www.theshore.net/~caker/uml/patches/token-limiter-v2.patch

> This patch also includes the proc-io_status patch.  It's against 2.6.9, but
> applies to 2.4-um as well.
>
> -Chris

Ok, seen that - to be cleaner, I'll change when I remember this to set, 
instead, tv_sec to 1 (tv_nsec cannot be one billion because one billion of 
nsec is one sec). I see that there is no actual difference and that doing 
this is a bit more invasive, so I guess that you fixed it this way on 
purpose, but, for merging, such things deserve cleaning. Also the proc status 
will have to be moved to a uml-only file.

Just a little thing, anyway - the patch is very nice.
-- 
Paolo Giarrusso, aka Blaisorblade
Linux registered user n. 292729
http://www.user-mode-linux.org/~blaisorblade


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now. 
http://productguide.itmanagersjournal.com/
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel