From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sc8-sf-mx1-b.sourceforge.net ([10.3.1.11] helo=sc8-sf-mx1.sourceforge.net) by sc8-sf-list1.sourceforge.net with esmtp (Exim 4.30) id 1Cf0bo-0005E3-TU for user-mode-linux-devel@lists.sourceforge.net; Thu, 16 Dec 2004 10:44:16 -0800 Received: from smtp003.mail.ukl.yahoo.com ([217.12.11.34]) by sc8-sf-mx1.sourceforge.net with smtp (Exim 4.41) id 1Cf0bm-0001Du-Iz for user-mode-linux-devel@lists.sourceforge.net; Thu, 16 Dec 2004 10:44:16 -0800 From: Blaisorblade References: <200412101645.iBAGjWA13367@trolli.pdb.fsc.net> <200412102228.07984.blaisorblade_spam@yahoo.it> <41BD9270.9020102@fujitsu-siemens.com> In-Reply-To: <41BD9270.9020102@fujitsu-siemens.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200412161924.19431.blaisorblade_spam@yahoo.it> Subject: [uml-devel] Re: [patch 1/1] make arch/um/kernel/skas/include/skas.h include asm/types.h Sender: user-mode-linux-devel-admin@lists.sourceforge.net Errors-To: user-mode-linux-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Id: The user-mode Linux development list List-Post: List-Help: List-Subscribe: , List-Archive: Date: Thu, 16 Dec 2004 19:24:19 +0100 To: Bodo Stroesser Cc: jdike@addtoit.com, user-mode-linux-devel@lists.sourceforge.net On Monday 13 December 2004 14:00, Bodo Stroesser wrote: > Blaisorblade wrote: > > On Friday 10 December 2004 17:45, bstroesser@fujitsu-siemens.com wrote: > >>From: Bodo Stroesser > >> > >>make arch/um/kernel/skas/include/skas.h include asm/types.h > >>This is necessary to have a typedef for __u64 > > > > *Probably* won't work, as headers in arch/um/include.... are also > > includable by userspace files, which can't include ; > > My patch changes arch/um/kernel/skas/include/skas.h, which is included by > arch/um/kernel/process.c in arch/um/kernel/Makefile, USER_OBJS lists it. > , arch/um/sys-XXXX/signal.c > and some > arch/um/kernel/skas/XXXX.c. IMHO, this should be safe, or do I miss > somesthing? Not exactly. The reference is the USER_OBJS content for those makefiles. An _user file is always for userspace, a _kern one for kernelspace, for others no fixed rule from the name. > well, it could happen > > > to include the *host* asm/types.h, which will be bad on a x86_64 host, > > since you could get a "unsigned long" (which is safe) even when compiling > > a 32-bit UML! > > > > Otherwise, there would not be includes in arch/um! They'd be in > > include/asm-um! > > > > And yes, this sucks, but is reality. > > > > Workaround it - unsigned long long is always a correct definition. > > This would be another possibility, but then the definition of "void map()" > in arch/um/kernel/skas/mem_user.c also should be changed. Yes, I agree... > I choosed the > option, which changes less. Feel free to choose the other one. -- Paolo Giarrusso, aka Blaisorblade Linux registered user n. 292729 http://www.user-mode-linux.org/~blaisorblade ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://productguide.itmanagersjournal.com/ _______________________________________________ User-mode-linux-devel mailing list User-mode-linux-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel