From: Blaisorblade <blaisorblade@yahoo.it>
To: user-mode-linux-devel@lists.sourceforge.net,
Frank Sorenson <frank@tuxrocks.com>,
Gerd Knorr <kraxel@bytesex.org>
Subject: Re: [uml-devel] [PATCH] Put the check for NULL before the use of a potentially-null value
Date: Tue, 11 Jan 2005 01:28:38 +0100 [thread overview]
Message-ID: <200501110128.38523.blaisorblade@yahoo.it> (raw)
In-Reply-To: <41E2F90C.4020707@tuxrocks.com>
On Monday 10 January 2005 22:52, Frank Sorenson wrote:
> This patch reorders two lines to check a variable for NULL before using
> the variable.
>
> Signed-off-by: Frank Sorenson <frank@tuxrocks.com>
diff -Naur linux-2.6.10-mm2.orig/arch/um/drivers/line.c
linux-2.6.10-mm2/arch/um/drivers/line.c
--- linux-2.6.10-mm2.orig/arch/um/drivers/line.c 2005-01-10
14:35:20.379815252 -0700
+++ linux-2.6.10-mm2/arch/um/drivers/line.c 2005-01-10 14:35:59.786829555
-0700
@@ -593,8 +593,8 @@
}
}
tty = winch->tty;
- line = tty->driver_data;
if (tty != NULL) {
+ line = tty->driver_data;
chan_window_size(&line->chan_list,
&tty->winsize.ws_row,
&tty->winsize.ws_col);
Ok, correct and thanks a lot.
Sorry, a little question: against what tree does it apply?
I cannot apply it locally, but I see that it should apply on top of Gerd
Knorr's terminal cleanup patch, which introduces the bug.
I hope I'll not forget it...
--
Paolo Giarrusso, aka Blaisorblade
Linux registered user n. 292729
http://www.user-mode-linux.org/~blaisorblade
-------------------------------------------------------
The SF.Net email is sponsored by: Beat the post-holiday blues
Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek.
It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
next prev parent reply other threads:[~2005-01-11 0:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-10 21:52 [uml-devel] [PATCH] Put the check for NULL before the use of a potentially-null value Frank Sorenson
2005-01-11 0:28 ` Blaisorblade [this message]
2005-01-11 1:06 ` Frank Sorenson
2005-01-11 9:13 ` Gerd Knorr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200501110128.38523.blaisorblade@yahoo.it \
--to=blaisorblade@yahoo.it \
--cc=frank@tuxrocks.com \
--cc=kraxel@bytesex.org \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox