From: Blaisorblade <blaisorblade@yahoo.it>
To: user-mode-linux-devel@lists.sourceforge.net
Cc: stian@nixia.no
Subject: Re: [uml-devel] df -h and hostfs
Date: Wed, 12 Jan 2005 01:10:32 +0100 [thread overview]
Message-ID: <200501120110.32416.blaisorblade@yahoo.it> (raw)
In-Reply-To: <62845.80.203.0.208.1105438274.squirrel@80.203.0.208>
On Tuesday 11 January 2005 11:11, stian@nixia.no wrote:
> when df -h does a statfs, hostfs statfs'es /, instead of the mount-source
> directory,
I.e. the one you see in the mount point inside UML...
> so you get the wrong stats about free-space if the mounted
> directory does not originate from the / host partition.
Yes, good idea... fixing it like you said will guarantee correct free space
stats (apart for quotas) but not correct used-space and total-space stats
(they would be possible only for humfs if it uses some accounting).
> Stian
However, by looking the code, I don't see an obvious way to trigger this
bug...
In:
static int hostfs_fill_sb_common(struct super_block *sb, void *d, int silent)
{
We have:
HOSTFS_I(root_inode)->host_filename = name;
And later, this value is reused (I actually checked this is supposed to refer
to the same thing) as:
err = do_statfs(HOSTFS_I(sb->s_root->d_inode)->host_filename,
So, could you double-check? I'll also try to reproduce it, if possible.
Bye
--
Paolo Giarrusso, aka Blaisorblade
Linux registered user n. 292729
http://www.user-mode-linux.org/~blaisorblade
-------------------------------------------------------
The SF.Net email is sponsored by: Beat the post-holiday blues
Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek.
It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
next prev parent reply other threads:[~2005-01-12 0:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-11 10:11 [uml-devel] df -h and hostfs stian
2005-01-12 0:10 ` Blaisorblade [this message]
2005-01-12 14:56 ` Henrik Nordstrom
-- strict thread matches above, loose matches on Subject: below --
2005-01-12 11:48 stian
2005-01-12 17:33 ` Blaisorblade
2005-01-12 18:22 ` stian
2005-01-12 18:36 ` Blaisorblade
2005-01-13 9:23 ` stian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200501120110.32416.blaisorblade@yahoo.it \
--to=blaisorblade@yahoo.it \
--cc=stian@nixia.no \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox