From: Jeff Dike <jdike@addtoit.com>
To: Linus Torvalds <torvalds@osdl.org>
Cc: linux-kernel@vger.kernel.org,
user-mode-linux-devel@lists.sourceforge.net
Subject: [uml-devel] [PATCH 4/16] UML - Get rid of uneccessary hostfs build trick
Date: Mon, 07 Mar 2005 15:37:42 -0500 [thread overview]
Message-ID: <200503072037.j27Kbgbc003957@ccure.user-mode-linux.org> (raw)
Get rid of the grepping for __st_ino in hostfs, since it doesn't work on x86_64
(the grep finds it, but it is ifdefed out), and Al says it's unnecessary
anyway.
Signed-off-by: Jeff Dike <jdike@addtoit.com>
Index: linux-2.6.11/fs/hostfs/Makefile
===================================================================
--- linux-2.6.11.orig/fs/hostfs/Makefile 2005-03-05 12:07:31.000000000 -0500
+++ linux-2.6.11/fs/hostfs/Makefile 2005-03-05 12:09:15.000000000 -0500
@@ -3,13 +3,6 @@
# Licensed under the GPL
#
-# struct stat64 changed the inode field name between 2.2 and 2.4 from st_ino
-# to __st_ino. It stayed in the same place, so as long as the correct name
-# is used, hostfs compiled on 2.2 should work on 2.4 and vice versa.
-
-STAT64_INO_FIELD := $(shell grep -q __st_ino /usr/include/bits/stat.h && \
- echo __)st_ino
-
hostfs-objs := hostfs_kern.o hostfs_user.o
obj-y =
@@ -20,7 +13,5 @@
USER_OBJS := $(filter %_user.o,$(obj-y) $(obj-m) $(SINGLE_OBJS))
USER_OBJS := $(foreach file,$(USER_OBJS),$(obj)/$(file))
-USER_CFLAGS += -DSTAT64_INO_FIELD=$(STAT64_INO_FIELD)
-
$(USER_OBJS) : %.o: %.c
$(CC) $(CFLAGS_$(notdir $@)) $(USER_CFLAGS) -c -o $@ $<
Index: linux-2.6.11/fs/hostfs/hostfs_user.c
===================================================================
--- linux-2.6.11.orig/fs/hostfs/hostfs_user.c 2005-03-05 12:07:31.000000000 -0500
+++ linux-2.6.11/fs/hostfs/hostfs_user.c 2005-03-05 12:09:15.000000000 -0500
@@ -28,10 +28,7 @@
if(lstat64(path, &buf) < 0)
return(-errno);
- /* See the Makefile for why STAT64_INO_FIELD is passed in
- * by the build
- */
- if(inode_out != NULL) *inode_out = buf.STAT64_INO_FIELD;
+ if(inode_out != NULL) *inode_out = buf.st_ino;
if(mode_out != NULL) *mode_out = buf.st_mode;
if(nlink_out != NULL) *nlink_out = buf.st_nlink;
if(uid_out != NULL) *uid_out = buf.st_uid;
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
reply other threads:[~2005-03-07 18:07 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200503072037.j27Kbgbc003957@ccure.user-mode-linux.org \
--to=jdike@addtoit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox