Re: [uml-devel] [patch 05/12] uml: extend cmd line limits

[Blaisorblade <blaisorblade@yahoo.it>]

[-- Attachment #1: Type: text/plain, Size: 540 bytes --]

On Tuesday 22 March 2005 22:30, Anthony Brock wrote:
> Blaisor,
>
> Perhaps the error message should be changed from:
>
> "add_arg: Too much command line!\n"
>
> to something like:
>
> "add_arg: Too many command line arguments!\n"
>
> Does this explain the error more clearly? Or am I mistaken?
Yes, I was copying it and didn't notice the message didn't make sense.

Here is the patch, it's queued and will be sent shortly.

-- 
Paolo Giarrusso, aka Blaisorblade
Linux registered user n. 292729
http://www.user-mode-linux.org/~blaisorblade

[-- Attachment #2: uml-correct-message.patch --]
[-- Type: text/x-diff, Size: 928 bytes --]


From: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>, "Anthony Brock" <Anthony_Brock@ous.edu>

Replace the message with a more meaningful one. Noted by Anthony Brock.

Signed-off-by: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
---

 linux-2.6.11-paolo/arch/um/kernel/um_arch.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

diff -puN arch/um/kernel/um_arch.c~uml-correct-message arch/um/kernel/um_arch.c
--- linux-2.6.11/arch/um/kernel/um_arch.c~uml-correct-message	2005-03-24 03:04:59.000000000 +0100
+++ linux-2.6.11-paolo/arch/um/kernel/um_arch.c	2005-03-24 03:05:36.000000000 +0100
@@ -47,7 +47,7 @@ char command_line[COMMAND_LINE_SIZE] = {
 void add_arg(char *arg)
 {
 	if (strlen(command_line) + strlen(arg) + 1 > COMMAND_LINE_SIZE) {
-		printf("add_arg: Too much command line!\n");
+		printf("add_arg: Too many command line arguments!\n");
 		exit(1);
 	}
 	if(strlen(command_line) > 0)
_