From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sc8-sf-mx1-b.sourceforge.net ([10.3.1.11] helo=sc8-sf-mx1.sourceforge.net) by sc8-sf-list1.sourceforge.net with esmtp (Exim 4.30) id 1DJSlP-0002vZ-LO for user-mode-linux-devel@lists.sourceforge.net; Thu, 07 Apr 2005 01:53:23 -0700 Received: from dsl092-053-140.phl1.dsl.speakeasy.net ([66.92.53.140] helo=grelber.thyrsus.com) by sc8-sf-mx1.sourceforge.net with esmtp (TLSv1:AES256-SHA:256) (Exim 4.41) id 1DJSlO-0002Fm-3E for user-mode-linux-devel@lists.sourceforge.net; Thu, 07 Apr 2005 01:53:23 -0700 From: Rob Landley Subject: Re: [uml-devel] Broken compiling under 2.6.12-rc2 on my machine References: <200504060145.24555.rob@landley.net> <200504062136.26895.blaisorblade@yahoo.it> In-Reply-To: <200504062136.26895.blaisorblade@yahoo.it> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Message-Id: <200504070250.10873.rob@landley.net> Sender: user-mode-linux-devel-admin@lists.sourceforge.net Errors-To: user-mode-linux-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Id: The user-mode Linux development list List-Post: List-Help: List-Subscribe: , List-Archive: Date: Thu, 7 Apr 2005 02:50:10 -0400 Content-Transfer-Encoding: quoted-printable To: Blaisorblade Cc: user-mode-linux-devel@lists.sourceforge.net, Ian McDonald On Wednesday 06 April 2005 03:36 pm, Blaisorblade wrote: > Anyway, from looking at what you quote, it's identical to the code in > arch/um/kernel/Makefile. Quoting the correct code: > > quiet_cmd_quote2 =3D QUOTE $@ > cmd_quote2 =3D sed -e '/CONFIG/{' \ > -e 's/"CONFIG"\;/""/' \ > -e 'r $(obj)/config.tmp' \ > -e 'a""\;' \ > -e '}' \ > $< > $@ > > As you see, there is a fourth expression, *here*. But it's -e '}'. > > This patch went in after 2.6.11, I'm noticing - wow, are releases getting > so slow? > > > > System is Debian Woody, > > Can you post your sed version? and Rob, can you then test it and fix the > code? Please save the correct config.c currently created and check it for > reference. I enabled SKAS mode and the build finished. The sed bit didn't break for m= e: CHK usr/initramfs_list QUOTE arch/um/kernel/config.tmp QUOTE arch/um/kernel/config.c CC arch/um/kernel/config.o And I'm using knoppix, which is based on debian. >From the error message, it seems to be complaining about the "a" command. = If=20 you're using a really really really old version of sed, it might insist on = a=20 gratuitous line break before the line to be added. (I know it did back in = the 1970's, but I didn't think anything remotely modern had that limitation= .) =20 So try splitting the command in half like this: cmd_quote2 =3D sed -e '/CONFIG/{' \ -e 's/"CONFIG"\;/""/' \ -e 'r $(obj)/config.tmp' \ -e 'a \' \ -e '""\;' \ -e '}' \ $< > $@ I just tried that here and it behaved the same way as the other version, fo= r=20 me... Rob ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_ide95&alloc_id=14396&op=CCk _______________________________________________ User-mode-linux-devel mailing list User-mode-linux-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel