[uml-devel] Re: NACK on shift-MM_COPY_SEGMENTS for API change

[Blaisorblade <blaisorblade@yahoo.it>]

On Friday 06 May 2005 13:04, Bodo Stroesser wrote:
> Blaisorblade wrote:
> > I understand the purpose of the patch; however, without any mention about
> > the effects (which would be IMHO bad) we no more copy LDT segments on
> > fork/clone, which is bad.
>
> No. The patch shifts code only, but AFAICS it doesn't alter the bahavior of
> UML/i386. If it does, that would be a bug in the patch!
>
> > The patch moves that to the call of modify_ldt, but that's an hack, since
> > currently it's perfectly legitimate that a child uses the father's LDT,
> > though maybe uncommon.
>
> No. Let's read the code before and after the change:
>
> Before the change, father's LDT is copied in new_mm() using
> MM_COPY_SEGMENTS. new_mm() only has one caller, which is
> init_new_context_skas().

> After the change, father's LDT is copied in init_new_ldt(), again
> using MM_COPY_SEGMENTS.
Ok, it turns out that I was simply misreading the patch (I didn't apply the 
patch, since I don't have the time to work on Jeff's tree too, beyond the 
release tree).
-- 
Paolo Giarrusso, aka Blaisorblade
Skype user "PaoloGiarrusso"
Linux registered user n. 292729
http://www.user-mode-linux.org/~blaisorblade





-------------------------------------------------------
This SF.Net email is sponsored by: NEC IT Guy Games.
Get your fingers limbered up and give it your best shot. 4 great events, 4
opportunities to win big! Highest score wins.NEC IT Guy Games. Play to
win an NEC 61 plasma display. Visit http://www.necitguy.com/?r=20
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel