linux-um archives
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Jeff Dike <jdike@addtoit.com>
Cc: akpm@osdl.org, torvalds@osdl.org, linux-kernel@vger.kernel.org,
	user-mode-linux-devel@lists.sourceforge.net
Subject: [uml-devel] Re: [PATCH 1/7] UML - set_tsk_need_resched
Date: Mon, 30 May 2005 09:59:32 +0200	[thread overview]
Message-ID: <20050530075931.GA13119@elf.ucw.cz> (raw)
In-Reply-To: <200505262230.j4QMUGVh014671@ccure.user-mode-linux.org>

Hi!

> This is the UML resched patch.  Please stick it in with the other arch resched
> fixes.
> 
> Signed-off-by: Jeff Dike <jdike@addtoit.com>
> 
> Index: linux-2.6.11/arch/um/kernel/process_kern.c
> ===================================================================
> --- linux-2.6.11.orig/arch/um/kernel/process_kern.c	2005-05-26 14:01:28.000000000 -0400
> +++ linux-2.6.11/arch/um/kernel/process_kern.c	2005-05-26 14:31:46.000000000 -0400
> @@ -188,6 +188,8 @@ void default_idle(void)
>  	current->mm = &init_mm;
>  	current->active_mm = &init_mm;
>  
> +        set_tsk_need_resched(current);
> +
>  	while(1){
>  		/* endless idle loop with no priority at all */
>  		SET_PRI(current);

Seems to me you are have some tabs-vs-spaces problems. Plus it would
be nice to write

	while (1) {
instead of
	while(1){
								Pavel


-------------------------------------------------------
This SF.Net email is sponsored by Yahoo.
Introducing Yahoo! Search Developer Network - Create apps using Yahoo!
Search APIs Find out how you can build Yahoo! directly into your own
Applications - visit http://developer.yahoo.net/?fr=offad-ysdn-ostg-q22005
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

      reply	other threads:[~2005-05-30  8:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-26 22:30 [uml-devel] [PATCH 1/7] UML - set_tsk_need_resched Jeff Dike
2005-05-30  7:59 ` Pavel Machek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050530075931.GA13119@elf.ucw.cz \
    --to=pavel@ucw.cz \
    --cc=akpm@osdl.org \
    --cc=jdike@addtoit.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    --cc=user-mode-linux-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox