From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sc8-sf-mx1-b.sourceforge.net ([10.3.1.91] helo=mail.sourceforge.net) by sc8-sf-list1.sourceforge.net with esmtp (Exim 4.30) id 1E3eTV-0006Fq-Ib for user-mode-linux-devel@lists.sourceforge.net; Fri, 12 Aug 2005 11:41:49 -0700 Received: from smtp002.mail.ukl.yahoo.com ([217.12.11.33]) by mail.sourceforge.net with smtp (Exim 4.44) id 1E3eTR-0006A9-Sw for user-mode-linux-devel@lists.sourceforge.net; Fri, 12 Aug 2005 11:41:49 -0700 From: Blaisorblade References: <20050728185655.9C6ADA3@zion.home.lan> <20050730160218.GB4585@ccure.user-mode-linux.org> In-Reply-To: <20050730160218.GB4585@ccure.user-mode-linux.org> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200508122037.38473.blaisorblade@yahoo.it> Subject: [uml-devel] Re: [patch 1/3] uml: share page bits handling between 2 and 3 level pagetables Sender: user-mode-linux-devel-admin@lists.sourceforge.net Errors-To: user-mode-linux-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Id: The user-mode Linux development list List-Post: List-Help: List-Subscribe: , List-Archive: Date: Fri, 12 Aug 2005 20:37:38 +0200 To: Jeff Dike Cc: linux-kernel@vger.kernel.org, user-mode-linux-devel@lists.sourceforge.net On Saturday 30 July 2005 18:02, Jeff Dike wrote: > On Thu, Jul 28, 2005 at 08:56:53PM +0200, blaisorblade@yahoo.it wrote: > > As obvious, a "core code nice cleanup" is not a "stability-friendly > > patch" so usual care applies. > These look reasonable, as they are what we discussed in Ottawa. > I'll put them in my tree and see if I see any problems. I would > suggest sending these in early after 2.6.13 if they seem OK. I've discovered that we're not the only one to miss dirty / accessed "hardware" bits: see include/asm-alpha/pgtable.h (they don't have the accessed bit). So maybe we could drop the "fault-on-access" thing. Also, note the comment before handle_pte_fault: /* * These routines also need to handle stuff like marking pages dirty * and/or accessed for architectures that don't do it in hardware (most * RISC architectures). The early dirtying is also good on the i386. */ I'm not able to find where we clean the dirty bit on a pte, however it's not only done by pte_mkclean, there are some macros like ptep_clear... in asm-generic/pgtable.h -- Inform me of my mistakes, so I can keep imitating Homer Simpson's "Doh!". Paolo Giarrusso, aka Blaisorblade (Skype ID "PaoloGiarrusso", ICQ 215621894) http://www.user-mode-linux.org/~blaisorblade ___________________________________ Yahoo! Mail: gratis 1GB per i messaggi e allegati da 10MB http://mail.yahoo.it ------------------------------------------------------- SF.Net email is Sponsored by the Better Software Conference & EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf _______________________________________________ User-mode-linux-devel mailing list User-mode-linux-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel