From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sc8-sf-mx1-b.sourceforge.net ([10.3.1.91] helo=mail.sourceforge.net) by sc8-sf-list1.sourceforge.net with esmtp (Exim 4.30) id 1E8jRn-00048Y-UW for user-mode-linux-devel@lists.sourceforge.net; Fri, 26 Aug 2005 12:01:03 -0700 Received: from parcelfarce.linux.theplanet.co.uk ([195.92.249.252] ident=93) by mail.sourceforge.net with esmtps (TLSv1:AES256-SHA:256) (Exim 4.44) id 1E8jRl-00019t-PT for user-mode-linux-devel@lists.sourceforge.net; Fri, 26 Aug 2005 12:01:04 -0700 From: Al Viro Message-ID: <20050826190339.GA9322@parcelfarce.linux.theplanet.co.uk> References: <20050826145749.03BFE24D661@zion.home.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050826145749.03BFE24D661@zion.home.lan> Subject: [uml-devel] Re: [patch 1/2] Fixup symlink function pointers for hppfs [for 2.6.13] Sender: user-mode-linux-devel-admin@lists.sourceforge.net Errors-To: user-mode-linux-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Id: The user-mode Linux development list List-Post: List-Help: List-Subscribe: , List-Archive: Date: Fri, 26 Aug 2005 20:03:39 +0100 To: blaisorblade@yahoo.it Cc: torvalds@osdl.org, akpm@osdl.org, jdike@addtoit.com, linux-kernel@vger.kernel.org, user-mode-linux-devel@lists.sourceforge.net On Fri, Aug 26, 2005 at 04:57:44PM +0200, blaisorblade@yahoo.it wrote: > > From: Paolo 'Blaisorblade' Giarrusso > > Update hppfs for the symlink functions prototype change. > Should be trivial, but please verify it's correct. > > Yes, I know the code I leave there is still _bogus_, see next patch for this. Assuming that the next patch was "hppfs: fix symlink error path", you've still left BS in there - > proc_file = dentry_open(dget(proc_dentry), NULL, O_RDONLY); is obviously wrong; at the very least you need vfsmount in there. ------------------------------------------------------- SF.Net email is Sponsored by the Better Software Conference & EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf _______________________________________________ User-mode-linux-devel mailing list User-mode-linux-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel