From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sc8-sf-mx1-b.sourceforge.net ([10.3.1.91] helo=mail.sourceforge.net) by sc8-sf-list1.sourceforge.net with esmtp (Exim 4.30) id 1EE9i8-0006iI-GM for user-mode-linux-devel@lists.sourceforge.net; Sat, 10 Sep 2005 11:04:20 -0700 Received: from ppp-62-11-72-160.dialup.tiscali.it ([62.11.72.160] helo=zion.home.lan) by mail.sourceforge.net with esmtp (Exim 4.44) id 1EE9i6-0002VB-KS for user-mode-linux-devel@lists.sourceforge.net; Sat, 10 Sep 2005 11:04:20 -0700 Message-Id: <20050910174629.706033000@zion.home.lan> References: <20050910174452.907256000@zion.home.lan> From: "Paolo 'Blaisorblade' Giarrusso" Content-Disposition: inline; filename=uml-avoid-already-done-dirtying Subject: [uml-devel] [patch 6/7] uml: avoid already done dirtying Sender: user-mode-linux-devel-admin@lists.sourceforge.net Errors-To: user-mode-linux-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Id: The user-mode Linux development list List-Post: List-Help: List-Subscribe: , List-Archive: Date: Sat, 10 Sep 2005 19:44:58 +0200 To: Linus Torvalds Cc: Jeff Dike , Paolo Blaisorblade Giarrusso , LKML , user-mode-linux-devel@lists.sourceforge.net The PTE returned from handle_mm_fault is already marked as dirty and accessed if needed. Also, since this is not set with set_pte() (which sets NEWPAGE and NEWPROT as needed), this wouldn't work anyway. This version has been updated and fixed, thanks to some feedback from Jeff Dike. Signed-off-by: Paolo 'Blaisorblade' Giarrusso --- arch/um/kernel/trap_kern.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/arch/um/kernel/trap_kern.c b/arch/um/kernel/trap_kern.c --- a/arch/um/kernel/trap_kern.c +++ b/arch/um/kernel/trap_kern.c @@ -85,8 +85,7 @@ survive: pte = pte_offset_kernel(pmd, address); } while(!pte_present(*pte)); err = 0; - *pte = pte_mkyoung(*pte); - if(pte_write(*pte)) *pte = pte_mkdirty(*pte); + WARN_ON(!pte_young(*pte) || (is_write && !pte_dirty(*pte))); flush_tlb_page(vma, address); out: up_read(&mm->mmap_sem); -- ------------------------------------------------------- SF.Net email is Sponsored by the Better Software Conference & EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf _______________________________________________ User-mode-linux-devel mailing list User-mode-linux-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel