From: Blaisorblade <blaisorblade@yahoo.it>
To: Al Viro <viro@ftp.linux.org.uk>
Cc: Antoine Martin <antoine@nagafix.co.uk>,
Al Viro <viro@zeniv.linux.org.uk>, Jeff Dike <jdike@addtoit.com>,
user-mode-linux-devel@lists.sourceforge.net,
LKML <linux-kernel@vger.kernel.org>
Subject: [uml-devel] Re: [PATCH 04/12] HPPFS: fix access to ppos and file->f_pos
Date: Wed, 21 Sep 2005 18:48:59 +0200 [thread overview]
Message-ID: <200509211848.59856.blaisorblade@yahoo.it> (raw)
In-Reply-To: <20050921034649.GX7992@ftp.linux.org.uk>
On Wednesday 21 September 2005 05:46, Al Viro wrote:
> On Sun, Sep 18, 2005 at 04:09:51PM +0200, Paolo 'Blaisorblade' Giarrusso
wrote:
> > static ssize_t read_proc(struct file *file, char *buf, ssize_t count,
> > loff_t *ppos, int is_user)
> > {
> > @@ -228,17 +237,21 @@ static ssize_t read_proc(struct file *fi
> > if (read == NULL)
> > return -EINVAL;
> >
> > + WARN_ON(is_user != (ppos != NULL));
> Eww.... Why not pass the right ppos in all cases?
Ok, can be done too. Was a bit in a hurry.
--
Inform me of my mistakes, so I can keep imitating Homer Simpson's "Doh!".
Paolo Giarrusso, aka Blaisorblade (Skype ID "PaoloGiarrusso", ICQ 215621894)
http://www.user-mode-linux.org/~blaisorblade
___________________________________
Yahoo! Mail: gratis 1GB per i messaggi e allegati da 10MB
http://mail.yahoo.it
-------------------------------------------------------
SF.Net email is sponsored by:
Tame your development challenges with Apache's Geronimo App Server. Download
it for free - -and be entered to win a 42" plasma tv or your very own
Sony(tm)PSP. Click here to play: http://sourceforge.net/geronimo.php
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
prev parent reply other threads:[~2005-09-21 16:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-18 14:09 [uml-devel] [PATCH 04/12] HPPFS: fix access to ppos and file->f_pos Paolo 'Blaisorblade' Giarrusso
2005-09-21 3:46 ` [uml-devel] " Al Viro
2005-09-21 16:48 ` Blaisorblade [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200509211848.59856.blaisorblade@yahoo.it \
--to=blaisorblade@yahoo.it \
--cc=antoine@nagafix.co.uk \
--cc=jdike@addtoit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=user-mode-linux-devel@lists.sourceforge.net \
--cc=viro@ftp.linux.org.uk \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox