[uml-devel] Re: UML/2.6.14-rc3 doesn't work fixes

[Blaisorblade <blaisorblade@yahoo.it>]

On Sunday 02 October 2005 22:54, Al Viro wrote:
> BTW, speaking of Kbuild cleanups (and that one is definitely 2.6.15
> fodder): patch below
> 	* kills messing with lib vs. core for uml-amd64 (we don't need that
> anymore)
I'm even curious why we needed that in first place.

> 	* kills symlinks in arch/um/sys-*/
> 	* kills foo.c-dir - we simply give HOST_OBJS=<list of pathnames
> under arch/$(SUBARCH)> and that's it (no SYMLINKS either)

> Price: use of make feature I really, really hate - $(eval ...). 
I looked at make Changelog, time ago, and this feature was added in make 3.80, 
so you'd need to update Documentation/Changes.

Make 3.80 was released in 2002-10-03, so I hope it's not a problem (should 
check on Debian Woody though, maybe).

> I'm using 
> it to generate and process
>
> bar-y := ../../$(SUBARCH)/foo/bar.o
> ...

> for all HOST_OBJS elements.  If there are better suggestions, I'd be glad
> to hear them...

The first thing is that HOST_OBJS is totally confusing... SUBARCH_OBJS or 
something else is better.

The second is that, even if x86_64 uses things such as  (from 
arch/x86_64/mm/Makefile):

obj-$(CONFIG_HUGETLB_PAGE) += hugetlbpage.o
hugetlbpage-y = ../../i386/mm/hugetlbpage.o
(because hugetlbpage.o is conditional)

we could as well do 

subarch-y := ../../$(SUBARCH)/name
(even with foreach)

for most things (see arch/x86_64/oprofile/Makefile), and for highmem and 
module I'd just do that by hand:

highmem-y := $(SUBARCH_DIR)/mm/highmem.o
module-y := $(SUBARCH_DIR)/kernel/module.o

with SUBARCH_DIR defined in arch/um/Makefile.
-- 
Inform me of my mistakes, so I can keep imitating Homer Simpson's "Doh!".
Paolo Giarrusso, aka Blaisorblade (Skype ID "PaoloGiarrusso", ICQ 215621894)
http://www.user-mode-linux.org/~blaisorblade


	

	
		
___________________________________ 
Yahoo! Mail: gratis 1GB per i messaggi e allegati da 10MB 
http://mail.yahoo.it



-------------------------------------------------------
This SF.Net email is sponsored by:
Power Architecture Resource Center: Free content, downloads, discussions,
and more. http://solutions.newsforge.com/ibmarch.tmpl
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel