Re: [uml-devel] Re: pcap cross-linking [PATCH]

[Blaisorblade <blaisorblade@yahoo.it>]

On Thursday 22 December 2005 18:57, Anthony Brock wrote:
> I don't think the attachment made it into the email.
It was in the previous one but I had forgot to describe it - sorry for the 
misunderstanding.

> However, I am 
> attaching one that we've used with good success. It allows us to also
> specify a "nice" level for the UML kernel in addition to the chroot-setuid.
Nice tool, well written.

Only one minor complaint: you do the following sequence (excluding error 
paths):

	chdir(chroot_dir);
	chroot(chroot_dir);

this will fail needlessly if a relative path is used.

Replacing the chroot with chroot(".") would be better, IMHO.

One question: would 
	chroot(chroot_dir);
	chdir("/");
work equally well?
I've not seen it used so I wonder (a bit) if there can be some hidden bug.
-- 
Inform me of my mistakes, so I can keep imitating Homer Simpson's "Doh!".
Paolo Giarrusso, aka Blaisorblade (Skype ID "PaoloGiarrusso", ICQ 215621894)
http://www.user-mode-linux.org/~blaisorblade

	

	
		
___________________________________ 
Yahoo! Mail: gratis 1GB per i messaggi e allegati da 10MB 
http://mail.yahoo.it



-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel