linux-um archives
 help / color / mirror / Atom feed
From: Blaisorblade <blaisorblade@yahoo.it>
To: Jeff Dike <jdike@addtoit.com>
Cc: user-mode-linux-devel@lists.sourceforge.net,
	wang lianwei <lianwei.wang@gmail.com>
Subject: Re: [uml-devel] The init_maps bug which cause mem map error
Date: Wed, 11 Jan 2006 16:52:38 +0100	[thread overview]
Message-ID: <200601111652.39727.blaisorblade@yahoo.it> (raw)
In-Reply-To: <20060111162151.GC10179@ccure.user-mode-linux.org>

On Wednesday 11 January 2006 17:21, Jeff Dike wrote:
> On Wed, Jan 11, 2006 at 12:39:59AM +0100, Blaisorblade wrote:
> > On Tuesday 10 January 2006 15:14, wang lianwei wrote:
> > (What happened to these bad "*" guys ;-) ? )

> Yeah, this would have been better expressed as a patch.

> > > total_len = phys_len + iomem_len + highmem_len;

> > Remember people: never compare apples with bananas (or whatever).

> Yup, sometimes I wish we had strongly typed integers...

Yeah :-] ...

I think in Java APIs tend to do almost that... not at that point, but they use 
distinct classes for Point and Dimension and Rectangle and whatsoever... and 
I even have to study these things.

> > Thanks for
> > the note. It's the first patch on my queue.

> OK, I was going to fix it here, but I'll just let you send it in.

Will be in my next queue flush...

> Does this fix the 2M iomem problem?

Ah, well, he's the reporter of that problem, and he also worked diagnosing 
it... compliments!

-- 
Inform me of my mistakes, so I can keep imitating Homer Simpson's "Doh!".
Paolo Giarrusso, aka Blaisorblade (Skype ID "PaoloGiarrusso", ICQ 215621894)
http://www.user-mode-linux.org/~blaisorblade

	
	
		
___________________________________ 
Yahoo! Messenger with Voice: chiama da PC a telefono a tariffe esclusive 
http://it.messenger.yahoo.com



-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

  reply	other threads:[~2006-01-11 15:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-10 14:14 [uml-devel] The init_maps bug which cause mem map error wang lianwei
2006-01-10 23:39 ` Blaisorblade
2006-01-11 16:21   ` Jeff Dike
2006-01-11 15:52     ` Blaisorblade [this message]
2006-01-12  7:57       ` Jeff Dike

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200601111652.39727.blaisorblade@yahoo.it \
    --to=blaisorblade@yahoo.it \
    --cc=jdike@addtoit.com \
    --cc=lianwei.wang@gmail.com \
    --cc=user-mode-linux-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox