From: Blaisorblade <blaisorblade@yahoo.it>
To: Jeff Dike <jdike@addtoit.com>
Cc: user-mode-linux-devel@lists.sourceforge.net, Olaf Hering <olh@suse.de>
Subject: Re: [uml-devel] arch/um/include/kern_util.h:35: error: 'CONFIG_NR_CPUS' undeclared
Date: Tue, 17 Jan 2006 15:13:38 +0100 [thread overview]
Message-ID: <200601171513.39404.blaisorblade@yahoo.it> (raw)
In-Reply-To: <20060117034504.GG17171@ccure.user-mode-linux.org>
On Tuesday 17 January 2006 04:45, Jeff Dike wrote:
> On Tue, Jan 17, 2006 at 02:22:59AM +0100, Blaisorblade wrote:
> > On Monday 16 January 2006 18:14, Olaf Hering wrote:
> > > It picks up the libc headers instead of the 2.6.15 ones.
> >
> > Yep, that's correct, the bug is that shouldn't be using CONFIG_NR_CPUS.
> No, I just fixed this. The bug is that chan_user.c includes kern_util.h,
> which is a kernel-only header.
Good thing.
> I made a bunch of similar changes today
> (os.h also included kern_util.h!).
In that case, if it's kern-only, it should go into asm-um. Not in the current
form, hopefully (you agree it's a mess, right? We just don't have time and
patience to clean it right now).
> Maybe we don't need idle_threads there anyway, but that's a separate issue.
Yep, I fixed it this way. idle_threads was moved to asm/smp.h and it was
included in files needing it.
--
Inform me of my mistakes, so I can keep imitating Homer Simpson's "Doh!".
Paolo Giarrusso, aka Blaisorblade (Skype ID "PaoloGiarrusso", ICQ 215621894)
http://www.user-mode-linux.org/~blaisorblade
___________________________________
Yahoo! Mail: gratis 1GB per i messaggi e allegati da 10MB
http://mail.yahoo.it
-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems? Stop! Download the new AJAX search engine that makes
searching your log files as easy as surfing the web. DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
next prev parent reply other threads:[~2006-01-17 14:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-16 17:14 [uml-devel] arch/um/include/kern_util.h:35: error: 'CONFIG_NR_CPUS' undeclared Olaf Hering
2006-01-17 1:22 ` Blaisorblade
2006-01-17 3:45 ` Jeff Dike
2006-01-17 5:52 ` Jeff Dike
2006-01-17 14:13 ` Blaisorblade [this message]
2006-01-17 20:24 ` Olaf Hering
2006-01-18 13:04 ` Olaf Hering
2006-01-18 14:37 ` Jeff Dike
2006-01-18 16:42 ` Blaisorblade
2006-01-19 0:08 ` Jeff Dike
2006-01-19 0:04 ` Blaisorblade
2006-01-19 4:18 ` Jeff Dike
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200601171513.39404.blaisorblade@yahoo.it \
--to=blaisorblade@yahoo.it \
--cc=jdike@addtoit.com \
--cc=olh@suse.de \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox